OWNERS: OTA may now approve all graph changes #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdodson
commented
Jul 14, 2020
| cincinnati-graph-data-approvers: | ||
| - crawford |
There was a problem hiding this comment.
@crawford Don't know if you wanted to be left in review/approval for graph changes or not. PTAL
|
I guess you can kick us out, but I'd be fine with just adding yourselves in... |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Release-admins have been root approvers since forever, so we're not kicking you out ;). |
wking
added a commit
to wking/cincinnati-graph-data
that referenced
this pull request
Sep 3, 2021
I'm pretty sure this is what Scott meant to do in 7dd81a9 (OWNERS: OTA team now owns all graph changes, 2020-07-14, openshift#330), and he just didn't think to look in the raw/ directory. This also saves us from having to attempt to maintain a release-admins alias (e.g. Alex no longer works for Red Hat, and none of the others have weighed in on graph-data changes in a while now). Most of the folks who used to be in release-admins have direct access to manipulate GitHub labels anyway, so they don't need to go through Prow to drop approval labels on anything; they can just do that directly via GitHub actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.