Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport support for static provisioning #62

Closed
wants to merge 2 commits into from
Closed

Backport support for static provisioning #62

wants to merge 2 commits into from

Conversation

jsafrane
Copy link

Backport kubernetes-sigs#1647 to 4.14

See the commits, the first one is actually the cherry-pick, the other ones are just huge vendor updates.

jsafrane added 2 commits April 16, 2024 13:04
@jsafrane
Cherry-pick 1647
5e597cc 
Cherry-pick
kubernetes-sigs#1647.

There were (almost) no conflicts in the actual code. I manually picked only
azure-related lines from go.mod.
@jsafrane
Bump dependencies
6aeeb0a 
- Bump Kubernetes libs to 1.28.4. It did not compile with 1.27.
- Fix controllerserver.go - CreatePrivateEndpoint is now `*bool`.
- go mod tidy && go mod vendor.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@jsafrane
Copy link
Author

/close

@openshift-ci openshift-ci bot closed this Apr 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 25, 2024

@jsafrane: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jsafrane