Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-2706 Delete console kernel argument #737

Closed
wants to merge 1 commit into from
Closed

MGMT-2706 Delete console kernel argument #737

wants to merge 1 commit into from

Conversation

YuviGold
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YuviGold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2020
@avishayt
Copy link
Contributor

/assign @carbonin

carbonin
carbonin requested changes Nov 25, 2020
View reviewed changes
Copy link
Member

@carbonin carbonin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things.

  1. I think the problematic value was ttyS0 according to the comment here
  2. The value of host.InstallerArgs should be a json array
  3. Doing it this way will mean this argument will be overwritten if the user makes any additional customization to this field. Is that okay?

@romfreiman
Copy link
Contributor

@cgwalters WDYT?

ohadlevy
ohadlevy reviewed Nov 25, 2020
View reviewed changes
internal/host/transition.go
@@ -74,6 +74,7 @@ func (th *transitionHandler) PostRegisterHost(sw stateswitch.StateSwitch, args s

sHost.host.StatusUpdatedAt = strfmt.DateTime(time.Now())
sHost.host.StatusInfo = swag.String(statusInfoDiscovering)
sHost.host.InstallerArgs = "--delete-karg 'console=tty0'"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be ttyS0

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or perhaps delete it via regexp

Copy link
Contributor Author

@YuviGold YuviGold Nov 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the decision from the remove console=ttyS0 on metal issue - all console defaults kargs can be dropped.
But as looking in the coreos-installer code it seems regex isn't implemented.

Copy link
Contributor Author

@YuviGold YuviGold Nov 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a PR for coreos-installer repository.
I guess it would take time.

@cgwalters
Copy link
Member

Hmm you'd do this unconditionally? Don't we potentially still want to keep it on some metal systems? That's the core problem here, we basically can't have a useful default today.

No objections from me to this if you want to change this default. But I would prefer if we tried to solve the problem more holistically/completely upstream.

@openshift-ci
Copy link

openshift-ci bot commented Apr 16, 2021

@YuviGold: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/subsystem-aws b0fc732 link /test subsystem-aws
ci/prow/e2e-metal-assisted-onprem b0fc732 link /test e2e-metal-assisted-onprem
ci/prow/images b0fc732 link /test images
ci/prow/e2e-metal-assisted b0fc732 link /test e2e-metal-assisted
ci/prow/subsystem-kubeapi-aws b0fc732 link /test subsystem-kubeapi-aws
ci/prow/ci-index b0fc732 link /test ci-index
ci/prow/assisted-operator-install-aws b0fc732 link /test assisted-operator-install-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Apr 16, 2021

@YuviGold: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2021
@YuviGold YuviGold closed this May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohadlevy ohadlevy ohadlevy left review comments

@carbonin carbonin carbonin requested changes

@nmagnezi nmagnezi Awaiting requested review from nmagnezi

@rollandf rollandf Awaiting requested review from rollandf

Assignees

@carbonin carbonin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@YuviGold @openshift-ci-robot @avishayt @romfreiman @cgwalters @ohadlevy @carbonin