Fix Variables Resolution in PipelineRun on Bitbucket Server #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed variable resloution in pipelinerun when a variable is
specified in PipelineRun definition e.g. {{ eventKey }}
PAC doesn't resolve all the fields of event payload.
https://issues.redhat.com/browse/SRVKP-6696
Signed-off-by: Zaki Shaikh <zashaikh@redhat.com>
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1817 +/- ##
==========================================
+ Coverage 65.17% 65.18% +0.01%
==========================================
Files 175 175
Lines 13529 13536 +7
==========================================
+ Hits 8817 8824 +7
Misses 4125 4125
Partials 587 587 ☔ View full report in Codecov by Sentry. |
|
/test go-testing |
Comment on lines
+13
to
+22
| Actor bbv1.UserWithLinks `json:"actor"` | ||
| PullRequest bbv1.PullRequest `json:"pullRequest"` | ||
| EventKey string `json:"eventKey"` | ||
|
|
||
| // Comment should be used when event is `pr:comment:added` or `pr:comment:edited`. | ||
| Comment bbv1.ActivityComment `json:"comment"` | ||
|
|
||
| // CommentParentID and PreviousComment should be used when event is `pr:comment:edited`. | ||
| CommentParentID string `json:"commentParentId"` | ||
| PreviousComment string `json:"previousComment"` |
There was a problem hiding this comment.
can we have unit test for these newly added ( EventKey, CommentParentID and PreviousComment ) fields
There was a problem hiding this comment.
@zakisk i am okay if you want to add tests in follow up PR so that we can merge this for PAC release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed variable resloution in pipelinerun when a variable is specified in PipelineRun definition e.g. {{ body.eventKey }} PAC doesn't resolve all the fields of event payload.
https://issues.redhat.com/browse/SRVKP-6696
Demo video:
demo.mp4
Changes
Submitter Checklist
📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).