Fix panic in PAC controller on delete tag event in GitLab

[zakisk]

fixed panic in PAC controller when a tag is deleted on gitlab.

https://issues.redhat.com/browse/SRVKP-6636

https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1727708590297089

Changes

Submitter Checklist

• 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

• ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

• ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

• 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

• 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

• 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.

• 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

[codecov]

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.91%. Comparing base (339f294) to head (70b7bda).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/provider/gitlab/parse_payload.go	62.50%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1783      +/-   ##
==========================================
- Coverage   64.91%   64.91%   -0.01%     
==========================================
  Files         175      175              
  Lines       13363    13371       +8     
==========================================
+ Hits         8675     8680       +5     
- Misses       4108     4110       +2     
- Partials      580      581       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chmouel]

seems like your test is failing on --- FAIL: TestGitlabDeleteTagEvent (16.82s)
have you tested it ?

    gitlab_delete_tag_event_test.go:49: assertion failed: error is not nil: could not find a match using the labelSelector: app.kubernetes.io/name=controller in container pac-controller for regexp: event Delete Tag Push Hook is not supported*

[zakisk]

@chmouel yes, tested on my local machine and it was working fine.

[zakisk]

/test

[chmouel]

if there is going to be a issue with the tag creation the tag will be kept on the repo? is there an issue if the tag is already on the repo wand we try to recreate it on the next test?

[zakisk]

@chmouel changed the way tag is created.

[chmouel]

can you add a defer to make sure the tag is deleted at the end of the run ?