Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install PyYAML package using system apt or dnf #1773

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Oct 10, 2024

or fallback to pip --break-system-packages
and reformat files

Fixes #1772

Changes

Submitter Checklist

  • 📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

  • ♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

  • ✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

  • 📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

  • 🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

  • 🎁 If feasible, please check if an end-to-end test can be added. See README for more details.

  • 🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

or fallback to pip --break-system-packages
and reformat files

Fixes openshift-pipelines#1772

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Add detailed comments and improve readability in the
GetAndUpdateInstallationID and matchRepos functions.
Update comments to better explain the logic and purpose
of the code. Fix minor typos in comments.
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.16%. Comparing base (9e71fa3) to head (d836da9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/provider/github/app/token.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1773      +/-   ##
==========================================
- Coverage   65.16%   65.16%   -0.01%     
==========================================
  Files         174      174              
  Lines       13246    13250       +4     
==========================================
+ Hits         8632     8634       +2     
- Misses       4041     4043       +2     
  Partials      573      573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chmouel chmouel merged commit a10162c into openshift-pipelines:main Oct 10, 2024
4 checks passed
@chmouel chmouel deleted the issue-1772-ci-is-failing-with-latest-ubuntu-on-gh-actions branch October 10, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

CI is failing with latest ubuntu on GH actions
1 participant