Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-1.14] [Backport] Fix bug in cert manager config (#15434) #787

Conversation

skonto
Copy link

@skonto skonto commented Aug 2, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

JIRA:

Does this PR needs for other branches:

Does this PR (patch) needs to update/drop in the future?:

JIRA:

* add test to cover cert manager config edge case

* fix edge case bug in cert manager config
@skonto skonto requested a review from ReToCode August 2, 2024 08:17
@openshift-ci openshift-ci bot requested a review from alanfx August 2, 2024 08:17
@openshift-ci openshift-ci bot added the approved label Aug 2, 2024
@skonto
Copy link
Author

skonto commented Aug 2, 2024

For release 1.15 we are going to do an update later.

@skonto skonto removed the request for review from alanfx August 2, 2024 08:20
Copy link

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Aug 5, 2024
Copy link

openshift-ci bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3864b8f into openshift-knative:release-v1.14 Aug 5, 2024
7 checks passed
@openshift-cherrypick-robot

@skonto: cannot checkout release-vX.Y: error checking out "release-vX.Y": exit status 1 error: pathspec 'release-vX.Y' did not match any file(s) known to git

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes:

JIRA:

Does this PR needs for other branches:

Does this PR (patch) needs to update/drop in the future?:

JIRA:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants