Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update serving and kourier to reference 0.19 images #751

Merged
merged 7 commits into from
Dec 15, 2020
Merged

Update serving and kourier to reference 0.19 images #751

merged 7 commits into from
Dec 15, 2020

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Dec 11, 2020

This patch changes to:

  • Update serving 0.19.0 & kourier 0.19.1 in olm-catalog/serverless-operator/project.yaml.
  • Remove 001-liveness.patch.
  • Add webhook pdb patch to 003-serving-pdb.patch.
  • Add domainmapping resource yaml.

/cc @markusthoemmes @matzew

@nak3
Copy link
Contributor Author

nak3 commented Dec 11, 2020

/retest

TestServicePostUpgrade failed due to insufficient cpu:

failed with message: 0/6 nodes are available: 3 Insufficient cpu, 3 node(s) had taint {node-role.kubernetes.io/master:

markusthoemmes
markusthoemmes reviewed Dec 11, 2020
View reviewed changes
olm-catalog/serverless-operator/project.yaml Outdated
eventing: 0.18.6
eventing_contrib: 0.18.0
kourier: 0.18.1
kourier: 0.19.1
cli: 0.18.4
maistra: 1.1.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try bump this to 2.0.0 too, should work now.

markusthoemmes
markusthoemmes approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks exactly correct, thank you!

I'll keep the LGTM off until we have the upgrade tests sorted.

/hold

@nak3
Copy link
Contributor Author

nak3 commented Dec 14, 2020

Again, lack of resources. domain-mapping webhook and controller added 30m + 100m CPU requests though..

failed with message: 0/6 nodes are available: 3 Insufficient cpu, 3 node(s) had taint {node-role.kubernetes.io/master: }, that the pod didn't tolerate.

@nak3
Copy link
Contributor Author

nak3 commented Dec 14, 2020

Not only upgrade test but also upstream test is broken now.
Activator's endpoint is missing. Same error happens on #753.

    e2e.go:169: Did not see activator endpoints in public service for g-r-p-c-unary-ping-v-bgddaywm-xw476.Last received values: Activator:[]PubSvc: [], WantActivators 0
    grpc_test.go:381: Never got Activator endpoints in the service: timed out waiting for the condition

@nak3
Copy link
Contributor Author

nak3 commented Dec 14, 2020

/retest

Infra issue. Only 4.6-operator-e2e-aws-ocp-46 has a strange issue but let's see another try.

@nak3
Copy link
Contributor Author

nak3 commented Dec 14, 2020

All image digests are not resolved well. I will retest later.

failed to resolve image to digest: Head \"https://registry.svc.ci.openshift.org/v2/openshift/knative-v0.19.0/manifests/knative-serving-test-pizzaplanetv1\": context deadline exceeded."}

@matzew
Copy link
Member

matzew commented Dec 14, 2020

@nak3 Eventing bits got merged, I think this needs a new rebase ... :-(

nak3 added 6 commits December 15, 2020 08:42
@nak3
Update to 0.19 image
4396b67 
This patch changes to:
- Update serving 0.19.0 & kourier 0.19.1 in `olm-catalog/serverless-operator/project.yaml`.
- Remove `001-liveness.patch`.
- Add webhook pdb patch to `003-serving-pdb.patch`.
- Add domainmapping resource yaml.
@nak3
IMAGE_ variable for domainmapping
2bde3db
@nak3
Fix validation error
f6224eb
@nak3
Update maistra to 2.0.0
459b263
@nak3
Scale up nodes before running upgrade test
bafb514
@nak3
Fix rebase mistake
dca7add
@nak3
Copy link
Contributor Author

nak3 commented Dec 15, 2020

/test 4.6-upstream-e2e-aws-ocp-46

infra issue.

markusthoemmes
markusthoemmes approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2b2020c into openshift-knative:master Dec 15, 2020
@imjasonh imjasonh mentioned this pull request Feb 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusthoemmes markusthoemmes markusthoemmes approved these changes

@matzew matzew Awaiting requested review from matzew

Assignees

@markusthoemmes markusthoemmes

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nak3 @matzew @openshift-ci-robot @markusthoemmes @openshift-merge-robot