Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4] A Generic ML Command in PPL #997

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c6b234c from #971

* Add generic ml command in ppl.

Signed-off-by: Jing Zhang <jngz@amazon.com>

* Recover ml client dependency.

Signed-off-by: Jing Zhang <jngz@amazon.com>

* Address the comments I.

Signed-off-by: Jing Zhang <jngz@amazon.com>

Signed-off-by: Jing Zhang <jngz@amazon.com>
(cherry picked from commit c6b234c)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner October 31, 2022 23:29
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Merging #997 (2880e76) into 2.4 (634e2ff) will decrease coverage by 2.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.4     #997      +/-   ##
============================================
- Coverage     97.60%   95.51%   -2.10%     
- Complexity     3185     3223      +38     
============================================
  Files           308      320      +12     
  Lines          7983     8716     +733     
  Branches        520      643     +123     
============================================
+ Hits           7792     8325     +533     
- Misses          190      334     +144     
- Partials          1       57      +56     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.18% <100.00%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/org/opensearch/sql/utils/MLCommonsConstants.java 0.00% <ø> (ø)
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <100.00%> (ø)
...a/org/opensearch/sql/analysis/TypeEnvironment.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/planner/logical/LogicalML.java 100.00% <100.00%> (ø)
...ch/sql/planner/logical/LogicalPlanNodeVisitor.java 100.00% <100.00%> (ø)
.../sql/planner/physical/PhysicalPlanNodeVisitor.java 100.00% <100.00%> (ø)
...ecutor/protector/OpenSearchExecutionProtector.java 100.00% <100.00%> (ø)
...rch/planner/physical/MLCommonsOperatorActions.java 67.36% <100.00%> (+66.06%) ⬆️
...ch/sql/opensearch/planner/physical/MLOperator.java 100.00% <100.00%> (ø)
...search/sql/opensearch/storage/OpenSearchIndex.java 100.00% <100.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@penghuo penghuo merged commit 460cff6 into 2.4 Nov 1, 2022
@github-actions github-actions bot deleted the backport/backport-971-to-2.4 branch November 1, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants