Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Enable legacy settings in new setting action #97

Merged
merged 2 commits into from
May 26, 2021

Conversation

chloe-zh
Copy link
Contributor

@chloe-zh chloe-zh commented May 26, 2021

Signed-off-by: Chloe Zhang chloezh1102@gmail.com

Description

Example 1:

PUT _opendistro/_sql/settings
{
  "transient" : {
    "opendistro.sql.enabled" : "false"
  }
}

Response:

#! Deprecation: [opendistro.ppl.enabled] setting was deprecated in OpenSearch and will be removed in a future release! See the breaking changes documentation for the next major version.
#! Deprecation: [opendistro.sql.enabled] setting was deprecated in OpenSearch and will be removed in a future release! See the breaking changes documentation for the next major version.
#! Deprecation: [PUT /_opendistro/_sql/settings] is deprecated! Use [PUT /_plugins/_query/settings] instead.
{
  "acknowledged" : true,
  "persistent" : { },
  "transient" : {
    "opendistro" : {
      "sql" : {
        "enabled" : "false"
      }
    }
  }
}

Example 2:

PUT _plugins/_query/settings
{
  "transient" : {
    "opendistro.ppl.enabled" : "false"
  }
}

Response:

#! Deprecation: [opendistro.sql.enabled] setting was deprecated in OpenSearch and will be removed in a future release! See the breaking changes documentation for the next major version.
#! Deprecation: [opendistro.ppl.enabled] setting was deprecated in OpenSearch and will be removed in a future release! See the breaking changes documentation for the next major version.
{
  "acknowledged" : true,
  "persistent" : { },
  "transient" : {
    "opendistro" : {
      "ppl" : {
        "enabled" : "false"
      }
    }
  }
}

Issues Resolved

#96

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh chloe-zh self-assigned this May 26, 2021
@chloe-zh chloe-zh linked an issue May 26, 2021 that may be closed by this pull request
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh chloe-zh marked this pull request as ready for review May 26, 2021 22:57
@chloe-zh chloe-zh requested review from dai-chen and penghuo May 26, 2021 22:57
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@dai-chen dai-chen merged commit 70752b5 into opensearch-project:develop May 26, 2021
@dai-chen dai-chen added the bug Something isn't working label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Legacy settings are rejected by RestQuerySettingAction
3 participants