Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Plugin Settings Backwards Compatibility #82

Merged
merged 23 commits into from
May 24, 2021

Conversation

chloe-zh
Copy link
Contributor

@chloe-zh chloe-zh commented May 21, 2021

Signed-off-by: Chloe Zhang chloezh1102@gmail.com

Description

Comparison between legacy and new settings

Component Setting Description Setting Name Endpoint Legacy Setting Name Legacy Endpoint
SQL Enable/Disable SQL component plugins.sql.enabled _plugins/_query/settings or _cluster/settings opendistro.sql.enabled _opendistro/_sql/settings
SQL Config SQL time limit for slow query plugins.sql.slow_log _plugins/_query/settings or _cluster/settings opendistro.sql.slowlog _opendistro/_sql/settings
SQL Config the cursor lifetime plugins.sql.cursor.keep_alive _plugins/_query/settings or _cluster/settings opendistro.sql.cursor.keep_alive _opendistro/_sql/settings
SQL Enable/Disable SQL delete statement plugins.sql.delete.enabled _plugins/_query/settings or _cluster/settings N/A N/A
PPL Enable/Disable PPL component plugins.ppl.enabled _plugins/_query/settings or _cluster/settings opendistro.ppl.enabled _opendistro/_ppl/settings
Common Config the memory limit for the circuit breaker plugins.query.memory_limit _plugins/_query/settings or _cluster/setting opendistro.ppl.query.memory_limit _cluster/settings
Common Config the query size limit plugins.query.size_limit _plugins/_query/settings or _cluster/settings opendistro.query.size_limit _cluster/settings

Issues Resolved

#63
#36
opendistro-for-elasticsearch/sql#981

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

chloe-zh added 2 commits May 20, 2021 19:21
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh chloe-zh changed the base branch from main to develop May 21, 2021 03:34
chloe-zh added 7 commits May 21, 2021 15:21
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh chloe-zh marked this pull request as ready for review May 22, 2021 02:58
@chloe-zh chloe-zh linked an issue May 22, 2021 that may be closed by this pull request
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
@chloe-zh chloe-zh requested review from dai-chen and penghuo May 22, 2021 03:29
chloe-zh added 9 commits May 21, 2021 23:08
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>
Signed-off-by: chloe-zh <chloezh1102@gmail.com>

@Override
public String getName() {
return "ppl_settings_action";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the name.

Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin Settings Backwards Compatibility
3 participants