Fix compile issue, add geo module as dependency #808
Conversation
Signed-off-by: penghuo <penghuo@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #808 +/- ##
=============================================
+ Coverage 62.76% 94.82% +32.05%
- Complexity 0 2912 +2912
=============================================
Files 10 291 +281
Lines 658 7780 +7122
Branches 118 566 +448
=============================================
+ Hits 413 7377 +6964
- Misses 192 349 +157
- Partials 53 54 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -92,6 +92,8 @@ dependencies { | |||
| implementation group: 'org.json', name: 'json', version:'20180813' | |||
| implementation group: 'org.apache.commons', name: 'commons-lang3', version: '3.10' | |||
| implementation group: 'org.opensearch', name: 'opensearch', version: "${opensearch_version}" | |||
| // add geo module as dependency. https://github.com/opensearch-project/OpenSearch/pull/4180/. | |||
There was a problem hiding this comment.
implementation will result into a jar hell. Because OpenSearch will include this jar.
I wonder why integration tests are not failing.
There was a problem hiding this comment.
compileOnly does not works. IT failed.
https://github.com/opensearch-project/sql/runs/8255337793?check_suite_focus=true
Signed-off-by: penghuo <penghuo@gmail.com>
There was a problem hiding this comment.
Had a chat with @penghuo.
Looks like the plugin fails to find the class during runtime.
We'll do a follow up as including another geo.jar doesnt hurt and will take care of it for next release.
This reverts commit ca18fd1. Signed-off-by: penghuo <penghuo@gmail.com>
Create Issue. opensearch-project/OpenSearch#4461 |
Signed-off-by: penghuo penghuo@gmail.com
Description
Fix build issue with 2.3 release. OpenSearch core move geo to separate module. opensearch-project/OpenSearch#4180. Plugin need add geo module as dependency.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.