Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated ClusterService and Using NodeClient to fetch meta data (#774) #792

Merged

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Aug 30, 2022

Signed-off-by: penghuo penghuo@gmail.com

Description

cherry pick. #774

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo penghuo requested a review from a team as a code owner August 30, 2022 00:44
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@codecov-commenter
Copy link

Codecov Report

Merging #792 (e5829f4) into main (eeb90cf) will decrease coverage by 32.09%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #792       +/-   ##
=============================================
- Coverage     94.85%   62.76%   -32.10%     
=============================================
  Files           288       10      -278     
  Lines          7839      658     -7181     
  Branches        571      118      -453     
=============================================
- Hits           7436      413     -7023     
+ Misses          349      192      -157     
+ Partials         54       53        -1     
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch/sql/opensearch/client/OpenSearchNodeClient.java
...rch/data/value/OpenSearchExprTextKeywordValue.java
...opensearch/sql/ppl/utils/UnresolvedPlanHelper.java
...ensearch/sql/expression/function/FunctionName.java
...ql/opensearch/storage/OpenSearchStorageEngine.java
.../org/opensearch/sql/sql/parser/AstSortBuilder.java
...l/response/format/SimpleJsonResponseFormatter.java
...h/sql/expression/function/OpenSearchFunctions.java
...age/serialization/DefaultExpressionSerializer.java
...earch/sql/data/utils/ReverseExprValueOrdering.java
... and 268 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@penghuo penghuo merged commit c2973a3 into opensearch-project:main Aug 31, 2022
@dai-chen dai-chen added the enhancement New feature or request label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants