-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links in the doc file. #705
Fix links in the doc file. #705
Conversation
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
@@ -4,8 +4,8 @@ | |||
* Microsoft Power BI Desktop | |||
* [OpenSearch](https://docs-beta.opensearch.org/opensearch/install/index/) | |||
* [OpenSearch SQL ODBC driver](https://docs-beta.opensearch.org/search-plugins/sql/odbc/) | |||
* [OpenSearch.mez](../../../bi-connectors/PowerBIConnector/bin/Release) | |||
* Optional: [sqlodbc_import.pbids](../../../bi-connectors/PowerBIConnector/PBIDSExamples) to help with repeated connections to the same server | |||
* [OpenSearchProject.mez](OpenSearchProject.mez) or [AmazonOpenSearchService.mez](AmazonOpenSearchService.mez) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the SETUP section below, it references the OpenSearch.mez file that should be updated (and make sure the folder mentioned is correct).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed in 7631358.
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Codecov Report
@@ Coverage Diff @@
## main #705 +/- ##
=============================================
- Coverage 94.74% 62.76% -31.99%
=============================================
Files 283 10 -273
Lines 7676 658 -7018
Branches 560 118 -442
=============================================
- Hits 7273 413 -6860
+ Misses 349 192 -157
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Yury Fridlyand yuryf@bitquilltech.com
Description
Typo hotfix for PR #665.
LinkChecker task passed for PR #665 even there were errors. Perhaps it is a bug in
LinkChecker
, but now it fails and blocks all other PRs.Issues Resolved
LinkChecker GHA to pass for new PRs.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.