Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in the doc file. #705

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

Signed-off-by: Yury Fridlyand yuryf@bitquilltech.com

Description

Typo hotfix for PR #665.
LinkChecker task passed for PR #665 even there were errors. Perhaps it is a bug in LinkChecker, but now it fails and blocks all other PRs.

Issues Resolved

LinkChecker GHA to pass for new PRs.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner July 21, 2022 18:21
joshuali925
joshuali925 previously approved these changes Jul 21, 2022
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@@ -4,8 +4,8 @@
* Microsoft Power BI Desktop
* [OpenSearch](https://docs-beta.opensearch.org/opensearch/install/index/)
* [OpenSearch SQL ODBC driver](https://docs-beta.opensearch.org/search-plugins/sql/odbc/)
* [OpenSearch.mez](../../../bi-connectors/PowerBIConnector/bin/Release)
* Optional: [sqlodbc_import.pbids](../../../bi-connectors/PowerBIConnector/PBIDSExamples) to help with repeated connections to the same server
* [OpenSearchProject.mez](OpenSearchProject.mez) or [AmazonOpenSearchService.mez](AmazonOpenSearchService.mez)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the SETUP section below, it references the OpenSearch.mez file that should be updated (and make sure the folder mentioned is correct).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed in 7631358.

Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@codecov-commenter
Copy link

Codecov Report

Merging #705 (7631358) into main (0b254ae) will decrease coverage by 31.98%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #705       +/-   ##
=============================================
- Coverage     94.74%   62.76%   -31.99%     
=============================================
  Files           283       10      -273     
  Lines          7676      658     -7018     
  Branches        560      118      -442     
=============================================
- Hits           7273      413     -6860     
+ Misses          349      192      -157     
+ Partials         54       53        -1     
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ssion/operator/arthmetic/MathematicalFunction.java
...ensearch/storage/system/OpenSearchSystemIndex.java
...ensearch/sql/planner/physical/PhysicalPlanDSL.java
.../java/org/opensearch/sql/data/model/ExprValue.java
...rg/opensearch/sql/planner/logical/LogicalSort.java
...org/opensearch/sql/analysis/QualifierAnalyzer.java
...ch/request/system/OpenSearchCatIndicesRequest.java
...ensearch/storage/script/sort/SortQueryBuilder.java
...search/sql/expression/window/WindowDefinition.java
...a/org/opensearch/sql/analysis/AnalysisContext.java
... and 263 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuali925 joshuali925 merged commit 592c58b into opensearch-project:main Jul 22, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the dev-hotfix-readme-links branch July 22, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants