Reverted UseSSL flag to false and removed invalid test case #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st. Test case could not be completed due to breaking Windows UI changes for disabling checkboxes when host protocol is specified. Signed-off-by: forestmvey <forestv@bitquilltech.com>
Reverted UseSSL flag to false and removed invalid test case
Codecov Report
@@ Coverage Diff @@
## main #671 +/- ##
=========================================
Coverage 94.69% 94.69%
Complexity 2816 2816
=========================================
Files 281 281
Lines 7592 7592
Branches 558 558
=========================================
Hits 7189 7189
Misses 349 349
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
penghuo
approved these changes
Jul 7, 2022
dai-chen
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To conform to previous versions of the ODBC driver I have reverted the
UseSSLflags default value tofalse. Removed one invalid test case that tested a mismatch between theUseSSLflag and a specified protocol in the host url. This functionality was not implemented as it broke the Windows UI fix that disallows a specified protocol not matching theUseSSLflag.Issues Resolved
Leave default configuration for
UseSSLflag asfalse.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.