Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.1] Fix fuzziness parsing in multi_match function. Update tests. #669

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a91c194 from #668

Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
(cherry picked from commit a91c194)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner June 29, 2022 22:26
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge after CI passes

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #669 (2dce080) into 2.1 (5f00b9f) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.1     #669      +/-   ##
============================================
- Coverage     94.76%   94.67%   -0.09%     
+ Complexity     2850     2801      -49     
============================================
  Files           281      280       -1     
  Lines          7699     7570     -129     
  Branches        564      558       -6     
============================================
- Hits           7296     7167     -129     
  Misses          349      349              
  Partials         54       54              
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.71% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cript/filter/lucene/relevance/MultiMatchQuery.java 100.00% <100.00%> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <0.00%> (ø)
...java/org/opensearch/sql/ppl/parser/AstBuilder.java 100.00% <0.00%> (ø)
.../org/opensearch/sql/ppl/antlr/PPLSyntaxParser.java 100.00% <0.00%> (ø)
.../org/opensearch/sql/sql/antlr/SQLSyntaxParser.java 100.00% <0.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <0.00%> (ø)
...h/sql/expression/function/OpenSearchFunctions.java 100.00% <0.00%> (ø)
...arch/storage/script/filter/FilterQueryBuilder.java 100.00% <0.00%> (ø)
.../filter/lucene/relevance/MatchBoolPrefixQuery.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f00b9f...2dce080. Read the comment docs.

@joshuali925
Copy link
Member

@Yury-Fridlyand
not an issue this time but could you set your public/display name and email on github to the same as local git config?

DCO in backport PRs will fail because your github profile doesn't match the name and email in your ~/.gitconfig

  2dce080688206b63501ea6c97dbe1e7bfaf2454a    
Expected "Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com>", 
but got "Yury Fridlyand <yuryf@bitquilltech.com>".

thanks

@Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand not an issue this time but could you set your public/display name and email on github to the same as local git config?

DCO in backport PRs will fail because your github profile doesn't match the name and email in your ~/.gitconfig

  2dce080688206b63501ea6c97dbe1e7bfaf2454a    
Expected "Yury-Fridlyand <88679692+Yury-Fridlyand@users.noreply.github.com>", 
but got "Yury Fridlyand <yuryf@bitquilltech.com>".

thanks

Thank you, fixed.
Shouldn't be an issue anymore.

@joshuali925 joshuali925 merged commit 864732a into 2.1 Jun 29, 2022
@github-actions github-actions bot deleted the backport/backport-668-to-2.1 branch June 29, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants