Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL/PPL API endpoint backward compatibility #66

Merged
merged 5 commits into from
May 19, 2021
Merged

SQL/PPL API endpoint backward compatibility #66

merged 5 commits into from
May 19, 2021

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented May 18, 2021 •
edited
Loading

Description

  1. Move old API endpoints to _plugins/_sql and _plugins/_ppl
  2. Put both in replacedRoutes() and leave routes() empty
  3. Replace old endpoint everywhere

Guideline: https://github.com/opensearch-project/opensearch-plugins/blob/main/UPGRADING.md#rest-apis-backward-compatibility
Reference PR: opensearch-project/anomaly-detection#35

Issues Resolved

#36

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen
Replace SQL endpoints
2c47f76 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen added backwards-compatibility SQL PPL Piped processing language labels May 18, 2021
@dai-chen dai-chen self-assigned this May 18, 2021
dai-chen added 3 commits May 18, 2021 13:40
@dai-chen
Replace other SQL and PPL endpoints
6813597 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Move all endpoints to _plugins
3a6e91e 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Merge branch 'develop' into sql-ppl-api-backward-compatibility
0faee8b
@dai-chen dai-chen marked this pull request as ready for review May 18, 2021 22:11
@dai-chen dai-chen requested review from chloe-zh, penghuo and dblock May 18, 2021 22:11
@dai-chen dai-chen mentioned this pull request May 18, 2021
Merged
6 tasks
chloe-zh
chloe-zh approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@chloe-zh chloe-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, thanks for the changes!

@dai-chen dai-chen merged commit 54c1363 into opensearch-project:develop May 19, 2021
@dai-chen dai-chen deleted the sql-ppl-api-backward-compatibility branch May 19, 2021 22:52
@chloe-zh chloe-zh mentioned this pull request May 25, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chloe-zh chloe-zh chloe-zh approved these changes

@penghuo penghuo Awaiting requested review from penghuo

@dblock dblock Awaiting requested review from dblock

Assignees

@dai-chen dai-chen

Labels
backwards-compatibility PPL Piped processing language SQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dai-chen @chloe-zh