Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPL integration with AD and ml-commons #468

Merged
merged 10 commits into from
Mar 9, 2022
Merged

PPL integration with AD and ml-commons #468

merged 10 commits into from
Mar 9, 2022

Conversation

jackiehanyang
Copy link
Contributor

@jackiehanyang jackiehanyang commented Mar 8, 2022

Description

This PR is for PPL integration with AD and ml-commons, and it adds two new commands: KMEANS and AD.

Issues Resolved

N/A

Issues Created

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jackiehanyang and others added 9 commits February 1, 2022 14:16
Signed-off-by: Jackie Han <hnyng@amazon.com>
Signed-off-by: jackieyanghan <jkhanjob@gmail.com>
Signed-off-by: jackieyanghan <jkhanjob@gmail.com>
Signed-off-by: jackieyanghan <jkhanjob@gmail.com>
Signed-off-by: jackieyanghan <jkhanjob@gmail.com>
Signed-off-by: jackieyanghan <jkhanjob@gmail.com>
Signed-off-by: jackieyanghan <jkhanjob@gmail.com>
Signed-off-by: jackieyanghan <jkhanjob@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #468 (c13a368) into main (10a9846) will increase coverage by 32.33%.
The diff coverage is 40.46%.

Impacted file tree graph

@@              Coverage Diff              @@
##               main     #468       +/-   ##
=============================================
+ Coverage     62.91%   95.25%   +32.33%     
- Complexity        0     2746     +2746     
=============================================
  Files            10      276      +266     
  Lines           658     7414     +6756     
  Branches        118      537      +419     
=============================================
+ Hits            414     7062     +6648     
- Misses          191      298      +107     
- Partials         53       54        +1     
Flag Coverage Δ
query-workbench 62.91% <ø> (ø)
sql-engine 98.40% <40.46%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/org/opensearch/sql/utils/MLCommonsConstants.java 0.00% <0.00%> (ø)
...org/opensearch/sql/opensearch/client/MLClient.java 0.00% <0.00%> (ø)
...ch/sql/opensearch/planner/physical/ADOperator.java 0.00% <0.00%> (ø)
...rch/planner/physical/MLCommonsOperatorActions.java 1.75% <1.75%> (ø)
...opensearch/planner/physical/MLCommonsOperator.java 30.43% <30.43%> (ø)
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/planner/logical/LogicalAD.java 100.00% <100.00%> (ø)
...ensearch/sql/planner/logical/LogicalMLCommons.java 100.00% <100.00%> (ø)
...ch/sql/planner/logical/LogicalPlanNodeVisitor.java 100.00% <100.00%> (ø)
.../sql/planner/physical/PhysicalPlanNodeVisitor.java 100.00% <100.00%> (ø)
... and 265 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a9846...c13a368. Read the comment docs.

Signed-off-by: jackieyanghan <jkhanjob@gmail.com>
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@penghuo penghuo merged commit eb1ede4 into opensearch-project:main Mar 9, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 9, 2022
Signed-off-by: jackieyanghan <jkhanjob@gmail.com>
(cherry picked from commit eb1ede4)
penghuo pushed a commit that referenced this pull request Mar 9, 2022
Signed-off-by: jackieyanghan <jkhanjob@gmail.com>
(cherry picked from commit eb1ede4)

Co-authored-by: Jackie Han <41348518+jackiehanyang@users.noreply.github.com>
@penghuo penghuo added the PPL Piped processing language label Mar 9, 2022
@joshuali925 joshuali925 mentioned this pull request Mar 11, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x PPL Piped processing language v1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants