Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release 3.0] Bump gradle 8.10.2 / JDK23 / 3.0.0.0-alpha1 on SQL plugin #3319

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[Release 3.0] Bump gradle 8.10.2 / JDK23 / 3.0.0.0-alpha1 on SQL plugin #3319

wants to merge 7 commits into from

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Feb 12, 2025 •
edited
Loading

Description

[Release 3.0] Bump gradle 8.10.2 / JDK23 / 3.0.0.0-alpha1 on SQL plugin

Related Issues

Closes #3315
#1880

Check List

  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] New functionality has javadoc added.
  • [ ] New functionality has a user manual doc added.
  • [ ] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon
Bump gradle 8.10.2 / JDK23 / 3.0.0.0-alpha1 on SQL plugin
c515a35 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon self-assigned this Feb 12, 2025
@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Feb 12, 2025 •
edited
Loading

Pending geospatial:


* What went wrong:
Could not determine the dependencies of task ':integ-test:integTest'.
> Could not resolve all files for configuration ':integ-test:zipArchive'.
   > Could not resolve org.opensearch.plugin:geospatial:3.0.0.0-alpha1-SNAPSHOT.
     Required by:

@peterzhuamazon peterzhuamazon mentioned this pull request Feb 12, 2025
Draft
1 task
@peterzhuamazon peterzhuamazon changed the title Bump gradle 8.10.2 / JDK23 / 3.0.0.0-alpha1 on SQL plugin [Release 3.0] Bump gradle 8.10.2 / JDK23 / 3.0.0.0-alpha1 on SQL plugin Feb 12, 2025
@peterzhuamazon peterzhuamazon mentioned this pull request Feb 12, 2025
Open
66 tasks
@peterzhuamazon
Copy link
Member Author

Now pending ml:


* What went wrong:
Execution failed for task ':opensearch:compileJava'.
> Could not resolve all files for configuration ':opensearch:compileClasspath'.
   > Could not resolve org.opensearch:opensearch-ml-client:3.0.0.0-alpha1-SNAPSHOT.
     Required by:
         project :opensearch

@peterzhuamazon
Update imports
afea919 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Update more imports and github actions with jdk23
5f283e6 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon marked this pull request as ready for review February 13, 2025 01:55
@peterzhuamazon
More imports
c992c92 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Apply spotless
3556d49 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Seems issues with jdk23 not very sure:



        Caused by:
        java.lang.IllegalStateException: Failed to load interface org.mockito.plugins.MockMaker implementation declared in java.lang.CompoundEnumeration@216c22ce
            at org.mockito.internal.configuration.plugins.PluginInitializer.loadImpl(PluginInitializer.java:56)
            at org.mockito.internal.configuration.plugins.PluginLoader.loadPlugin(PluginLoader.java:65)
            at org.mockito.internal.configuration.plugins.PluginLoader.loadPlugin(PluginLoader.java:49)
            at org.mockito.internal.configuration.plugins.PluginRegistry.<init>(PluginRegistry.java:29)
            at org.mockito.internal.configuration.plugins.Plugins.<clinit>(Plugins.java:26)
            at org.mockito.internal.MockitoCore.<clinit>(MockitoCore.java:71)
            at org.mockito.Mockito.<clinit>(Mockito.java:1741)
            at org.mockito.junit.jupiter.MockitoExtension.beforeEach(MockitoExtension.java:155)
            ... 2 more

            Caused by:
            java.lang.reflect.InvocationTargetException
                at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:501)
                at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:485)
                at org.mockito.internal.configuration.plugins.PluginInitializer.loadImpl(PluginInitializer.java:51)
                ... 9 more

                Caused by:
                org.mockito.exceptions.base.MockitoInitializationException:
                Could not initialize inline Byte Buddy mock maker.

                It appears as if your JDK does not supply a working agent attachment mechanism.
                Java               : 23
                JVM vendor name    : Eclipse Adoptium
                JVM vendor version : 23.0.2+7
                JVM name           : OpenJDK 64-Bit Server VM
                JVM version        : 23.0.2+7
                JVM info           : mixed mode, sharing
                OS name            : Linux
                OS version         : 5.10.233-204.894.amzn2int.x86_64
                    at app//org.mockito.internal.creation.bytebuddy.InlineDelegateByteBuddyMockMaker.<init>(InlineDelegateByteBuddyMockMaker.java:254)
                    at app//org.mockito.internal.creation.bytebuddy.InlineByteBuddyMockMaker.<init>(InlineByteBuddyMockMaker.java:23)
                    ... 12 more

                    Caused by:
                    java.lang.IllegalStateException: Failed to resolve the class file version of the current VM: Unknown Java version: 0
                        at net.bytebuddy.ClassFileVersion$VersionLocator$Unresolved.resolve(ClassFileVersion.java:667)
                        at net.bytebuddy.ClassFileVersion.ofThisVm(ClassFileVersion.java:349)
                        at org.mockito.internal.PremainAttachAccess.getInstrumentation(PremainAttachAccess.java:36)
                        at org.mockito.internal.creation.bytebuddy.InlineDelegateByteBuddyMockMaker.<clinit>(InlineDelegateByteBuddyMockMaker.java:138)
                        ... 13 more

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Feb 13, 2025 •
edited
Loading

See it here:

                java.lang.IllegalArgumentException: Java 23 (67) is not supported by the current version of Byte Buddy which officially supports Java 22 (66) - update Byte Buddy or set net.bytebuddy.experimental as a VM property

Will update 1.14.19 (1.14.16 supports JDK23)

sql-3.0.0.0-alpha1-jdk23-error-log.txt

@peterzhuamazon
Update byte-buddy to 1.14.19 to support JDK23
1d766ac 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Now JDK23 has the same errors on integTest as JDK21:
sql-3.0.0.0-alpha1-jdk23-error-log2.txt

@peterzhuamazon
Copy link
Member Author

Adding @noCharger to take a look at integTest as he is the release manager for SQL.

Thanks!

noCharger
noCharger reviewed Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One major isssue from the log:

»  java.lang.IllegalArgumentException: No enum constant org.opensearch.action.search.SearchPhaseName.CREATE_PIT

> Task :integ-test:integTest FAILED

This is tracking opensearch-project/OpenSearch#16750
Bugfix opensearch-project/OpenSearch#16781

@noCharger
Copy link
Collaborator

Some other IT failed, which might be transient:

REPRODUCE WITH: gradlew ':integ-test:integTest' --tests "org.opensearch.sql.legacy.AggregationIT.termsWithMissing" -Dtests.seed=FF8898E23121F455 -Dtests.security.manager=false -Dtests.locale=os -Dtests.timezone=CET -Druntime.java=21

AggregationIT > termsWithMissing FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([FF8898E23121F455:CAA7D9E22B98F403]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.sql.legacy.AggregationIT.termsWithMissing(AggregationIT.java:449)

@peterzhuamazon peterzhuamazon mentioned this pull request Feb 13, 2025
Merged
3 tasks
@peterzhuamazon
Update bwc test
8df7993 
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Seems like same issues as this one:

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Feb 15, 2025 •
edited
Loading

New Failures on the build test, not integTest anymore after updating security snapshots:


2025-02-14T23:24:14.7130535Z > Task :doctest:doctest FAILED
2025-02-14T23:24:14.7131137Z ======================================================================
2025-02-14T23:24:14.7131683Z FAIL: /__w/sql/sql/doctest/../docs/user/dql/functions.rst
2025-02-14T23:24:14.7132155Z Doctest: functions.rst
2025-02-14T23:24:14.7132566Z ----------------------------------------------------------------------
2025-02-14T23:24:14.7133076Z Traceback (most recent call last):
2025-02-14T23:24:14.7133808Z   File "/usr/local/lib/python3.9/doctest.py", line 2204, in runTest
2025-02-14T23:24:14.7134247Z     raise self.failureException(self.format_failure(new.getvalue()))
2025-02-14T23:24:14.7134627Z AssertionError: Failed doctest test for functions.rst
2025-02-14T23:24:14.7135377Z   File "/__w/sql/sql/doctest/../docs/user/dql/functions.rst", line 0
2025-02-14T23:24:14.7135803Z 
2025-02-14T23:24:14.7136011Z ----------------------------------------------------------------------
2025-02-14T23:24:14.7136977Z File "/__w/sql/sql/doctest/../docs/user/dql/functions.rst", line 4328, in functions.rst
2025-02-14T23:24:14.7137355Z Failed example:
2025-02-14T23:24:14.7137826Z     sql_cmd.process("select id, title, author, _score from books where score(query('title:Pooh House', default_operator='AND'), 2.0)")Expected:
2025-02-14T23:24:14.7138341Z     fetched rows / total rows = 1/1
2025-02-14T23:24:14.7138618Z     +----+--------------------------+----------------------+-----------+
2025-02-14T23:24:14.7138942Z     | id | title                    | author               | _score    |
2025-02-14T23:24:14.7139677Z     |----+--------------------------+----------------------+-----------|
2025-02-14T23:24:14.7143292Z     | 1  | The House at Pooh Corner | Alan Alexander Milne | 1.5884793 |
2025-02-14T23:24:14.7144141Z     +----+--------------------------+----------------------+-----------+
2025-02-14T23:24:14.7144644Z Got:
2025-02-14T23:24:14.7144929Z     fetched rows / total rows = 1/1
2025-02-14T23:24:14.7145415Z     +----+--------------------------+----------------------+----------+
2025-02-14T23:24:14.7145949Z     | id | title                    | author               | _score   |
2025-02-14T23:24:14.7146469Z     |----+--------------------------+----------------------+----------|
2025-02-14T23:24:14.7147028Z     | 1  | The House at Pooh Corner | Alan Alexander Milne | 0.722036 |
2025-02-14T23:24:14.7147574Z     +----+--------------------------+----------------------+----------+
2025-02-14T23:24:14.7148102Z ----------------------------------------------------------------------
2025-02-14T23:24:14.7148810Z File "/__w/sql/sql/doctest/../docs/user/dql/functions.rst", line 4336, in functions.rst
2025-02-14T23:24:14.7149431Z Failed example:
2025-02-14T23:24:14.7150471Z     sql_cmd.process("select id, title, author, _score from books where score(query('title:Pooh House', default_operator='AND'), 5.0) OR score(query('title:Winnie', default_operator='AND'), 1.5)")Expected:
2025-02-14T23:24:14.7151608Z     fetched rows / total rows = 2/2
2025-02-14T23:24:14.7152057Z     +----+--------------------------+----------------------+-----------+
2025-02-14T23:24:14.7152577Z     | id | title                    | author               | _score    |
2025-02-14T23:24:14.7153091Z     |----+--------------------------+----------------------+-----------|
2025-02-14T23:24:14.7153825Z     | 1  | The House at Pooh Corner | Alan Alexander Milne | 3.9711983 |
2025-02-14T23:24:14.7154427Z     | 2  | Winnie-the-Pooh          | Alan Alexander Milne | 1.1581701 |
2025-02-14T23:24:14.7155942Z     +----+--------------------------+----------------------+-----------+
2025-02-14T23:24:14.7156427Z Got:
2025-02-14T23:24:14.7156714Z     fetched rows / total rows = 2/2
2025-02-14T23:24:14.7157171Z     +----+--------------------------+----------------------+------------+
2025-02-14T23:24:14.7157716Z     | id | title                    | author               | _score     |
2025-02-14T23:24:14.7158270Z     |----+--------------------------+----------------------+------------|
2025-02-14T23:24:14.7158913Z     | 1  | The House at Pooh Corner | Alan Alexander Milne | 1.8050902  |
2025-02-14T23:24:14.7159554Z     | 2  | Winnie-the-Pooh          | Alan Alexander Milne | 0.52644086 |
2025-02-14T23:24:14.7160175Z     +----+--------------------------+----------------------+------------+
2025-02-14T23:24:14.7160563Z 
2025-02-14T23:24:14.7160571Z 
2025-02-14T23:24:14.7160798Z ----------------------------------------------------------------------

cc: @noCharger

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noCharger noCharger noCharger left review comments

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@peterzhuamazon peterzhuamazon

Labels
release v3.0.0
Projects
Engineering Effectiveness Board
Status: 👀 In Review
OpenSearch Engineering Effectiveness
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump gradle to 8.10.2 and add JDK23 as part of the github checks
2 participants
@peterzhuamazon @noCharger