[POC] Make Calcite execute successfully #3258
Open
+128
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noCharger
reviewed
Jan 21, 2025
Signed-off-by: Heng Qian <qianheng@amazon.com>
…able when visitRelation. Signed-off-by: Heng Qian <qianheng@amazon.com>
148b79c to
cf34fab
Compare
Yeah, but it should only be merged to the feature branch |
penghuo
reviewed
Jan 29, 2025
| @@ -102,30 +113,50 @@ public ExplainResponseNode visitTableScan( | |||
| @Override | |||
| public void execute( | |||
| RelNode rel, CalcitePlanContext context, ResponseListener<QueryResponse> listener) { | |||
| try (PreparedStatement statement = RelRunners.run(rel)) { | |||
| Connection connection = context.connection; | |||
| final RelShuttle shuttle = new RelHomogeneousShuttle(); | |||
| @Override | ||
| public Table get(Object key) { | ||
| if (!super.containsKey(key)) { | ||
| registerTable((String) key); |
There was a problem hiding this comment.
could we do registerTable(new QualifiedName((String)key)) instead?
Comment on lines
+46
to
+54
| try { | ||
| this.statement = connection.createStatement().unwrap(CalciteServerStatement.class); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException("create statement failed", e); | ||
| } | ||
| this.prepare = new CalcitePrepareImpl(); | ||
| this.relBuilder = prepare.perform(statement, config, | ||
| (cluster, relOptSchema, rootSchema, statement) -> new OSRelBuilder(config.getContext(), | ||
| cluster, relOptSchema)); |
There was a problem hiding this comment.
could u help explain the purpose this statement?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.