Add SparkDataType as wrapper for unmapped spark data type #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peng Huo <penghuo@gmail.com>
dai-chen
previously approved these changes
Jan 31, 2024
.../java/org/opensearch/sql/spark/functions/response/DefaultSparkSqlFunctionResponseHandle.java
Show resolved
Hide resolved
| column.getName(), new ExprTimestampValue(row.getString(column.getName()))); | ||
| } else if (type == ExprCoreType.STRING) { | ||
| linkedHashMap.put(column.getName(), new ExprStringValue(row.getString(column.getName()))); | ||
| } else { |
There was a problem hiding this comment.
Just for understanding: anything apart from above datatypes is a SparkDataType.
There was a problem hiding this comment.
yes, any spark datatype sql can not mapping to is wrapped as SparkDataType.
The major reason for doing this mapping is event analysis frontend feature use SQL data type to display type icon.
|
Thanks for the fix. LGTM |
vamsimanohar
previously approved these changes
Jan 31, 2024
Signed-off-by: Peng Huo <penghuo@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2492 +/- ##
=========================================
Coverage 95.41% 95.41%
- Complexity 5000 5006 +6
=========================================
Files 479 481 +2
Lines 13950 13963 +13
Branches 937 940 +3
=========================================
+ Hits 13310 13323 +13
Misses 618 618
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dai-chen
approved these changes
Jan 31, 2024
vamsimanohar
approved these changes
Feb 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Add SparkDataType as wrapper for unmapped spark data type Signed-off-by: Peng Huo <penghuo@gmail.com> * add IT for parsing explain query reponse Signed-off-by: Peng Huo <penghuo@gmail.com> --------- Signed-off-by: Peng Huo <penghuo@gmail.com> (cherry picked from commit e59bf75) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo
pushed a commit
that referenced
this pull request
Feb 1, 2024
) * Add SparkDataType as wrapper for unmapped spark data type * add IT for parsing explain query reponse --------- (cherry picked from commit e59bf75) Signed-off-by: Peng Huo <penghuo@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add SparkDataType as wrapper for unmapped spark data type
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.