Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent arn changes in Patch datasources API #2349

Closed

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Oct 24, 2023

Description

Prevent arn changes in Patch datasources API

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2349 (f1d78bb) into main (877c9c3) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##               main    #2349      +/-   ##
============================================
- Coverage     96.45%   96.45%   -0.01%     
- Complexity     4898     4900       +2     
============================================
  Files           464      464              
  Lines         13418    13426       +8     
  Branches        903      903              
============================================
+ Hits          12943    12950       +7     
+ Misses          456      454       -2     
- Partials         19       22       +3     
Flag Coverage Δ
sql-engine 96.45% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../model/transport/PatchDataSourceActionRequest.java 36.84% <80.00%> (+15.41%) ⬆️

... and 2 files with indirect coverage changes

@derek-ho derek-ho closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant