Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spotless] Applying Google Code Format for opensearch directory #16 #1977

Merged
merged 11 commits into from
Aug 18, 2023
Merged

[Spotless] Applying Google Code Format for opensearch directory #16 #1977

merged 11 commits into from
Aug 18, 2023

Conversation

MitchellGale
Copy link
Contributor

Description

Applies spotless for opensearch directory in project. Sets checkstyle to not fail on failure for opensearch directory.

Issues Resolved

#1101

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@MitchellGale
spotless apply for OpenSearch P1.
cecba8a 
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@MitchellGale MitchellGale force-pushed the dev/sl_GoogleJavaFormat16 branch from 8aece8a to cecba8a Compare August 16, 2023 22:56
@MitchellGale MitchellGale changed the title [Spotless] Applying Google Code Format for opensearch directory #15 [Spotless] Applying Google Code Format for opensearch directory #16 Aug 16, 2023
@MitchellGale
Manual spotless changes
f5b2748 
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@MitchellGale
ignore failures for checkstyles.
6b532cb 
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@codecov
Copy link

codecov bot commented Aug 16, 2023 •
edited
Loading

Codecov Report

Merging #1977 (dbc818a) into main (491a73b) will decrease coverage by 0.19%.
Report is 6 commits behind head on main.
The diff coverage is 82.37%.

@@             Coverage Diff              @@
##               main    #1977      +/-   ##
============================================
- Coverage     97.51%   97.33%   -0.19%     
  Complexity     4656     4656              
============================================
  Files           408      408              
  Lines         11932    12063     +131     
  Branches        829      829              
============================================
+ Hits          11636    11741     +105     
- Misses          289      315      +26     
  Partials          7        7
Flag Coverage Δ
sql-engine 97.33% <82.37%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...org/opensearch/sql/opensearch/client/MLClient.java 0.00% <ø> (ø)
...sql/opensearch/data/type/OpenSearchBinaryType.java 100.00% <ø> (ø)
...ensearch/data/value/OpenSearchExprBinaryValue.java 100.00% <ø> (ø)
...nsearch/executor/protector/ExecutionProtector.java 100.00% <ø> (ø)
...rch/executor/protector/NoopExecutionProtector.java 100.00% <ø> (ø)
...ch/sql/opensearch/planner/physical/ADOperator.java 0.00% <0.00%> (ø)
...ch/request/system/OpenSearchCatIndicesRequest.java 100.00% <ø> (ø)
...earch/response/agg/CompositeAggregationParser.java 100.00% <ø> (ø)
...arch/sql/opensearch/response/agg/FilterParser.java 100.00% <ø> (ø)
...search/response/agg/NoBucketAggregationParser.java 100.00% <ø> (ø)
... and 42 more

... and 70 files with indirect coverage changes

@MitchellGale MitchellGale mentioned this pull request Aug 16, 2023
Merged
6 tasks
@MitchellGale MitchellGale mentioned this pull request Aug 17, 2023
Closed
@MitchellGale @Yury-Fridlyand
Apply suggestions from code review
81d40df 
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
MitchellGale and others added 4 commits August 17, 2023 09:36
@MitchellGale @Yury-Fridlyand
Apply suggestions from code review
9274d53 
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
@MitchellGale @Yury-Fridlyand
Apply suggestions from code review
d4f50c0 
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
@MitchellGale
Address PR comment
4150908 
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@MitchellGale
add order list in Content.java
854f0f7 
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Aug 17, 2023
View reviewed changes
@MitchellGale @GumpacG
Update opensearch/src/main/java/org/opensearch/sql/opensearch/request…
2768f29 
…/system/OpenSearchDescribeIndexRequest.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
@MitchellGale @GumpacG
Update opensearch/src/main/java/org/opensearch/sql/opensearch/respons…
4e84c3b 
…e/agg/MetricParserHelper.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
@Yury-Fridlyand
Copy link
Collaborator

You have compilation errors

@MitchellGale
Fixing compilation error
dbc818a 
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
@Yury-Fridlyand Yury-Fridlyand merged commit 56aa572 into opensearch-project:main Aug 18, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the dev/sl_GoogleJavaFormat16 branch August 18, 2023 16:28
This was referenced Aug 18, 2023
Merged
Merged
MitchellGale added a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 22, 2023
@MitchellGale @Yury-Fridlyand @GumpacG
[Spotless] Applying Google Code Format for opensearch directory #16 (o…
c36c1dc 
…pensearch-project#1977)

* spotless apply for OpenSearch P1.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Manual spotless changes

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* ignore failures for checkstyles.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Apply suggestions from code review

Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Address PR comment

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* add order list in Content.java

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Update opensearch/src/main/java/org/opensearch/sql/opensearch/request/system/OpenSearchDescribeIndexRequest.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Update opensearch/src/main/java/org/opensearch/sql/opensearch/response/agg/MetricParserHelper.java

Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

* Fixing compilation error

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

---------

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GumpacG GumpacG GumpacG approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MitchellGale @Yury-Fridlyand @GumpacG