-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter datasource encryption master key from cluster settings GET API #1825
Merged
vamsimanohar
merged 1 commit into
opensearch-project:main
from
vamsimanohar:restrict-master-key-in-cluster-settings-api
Jul 11, 2023
Merged
Filter datasource encryption master key from cluster settings GET API #1825
vamsimanohar
merged 1 commit into
opensearch-project:main
from
vamsimanohar:restrict-master-key-in-cluster-settings-api
Jul 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuali925
previously approved these changes
Jul 10, 2023
Yury-Fridlyand
previously approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an IT? Thanks
Codecov Report
@@ Coverage Diff @@
## main #1825 +/- ##
=========================================
Coverage 97.33% 97.33%
Complexity 4490 4490
=========================================
Files 394 394
Lines 11118 11119 +1
Branches 795 795
=========================================
+ Hits 10822 10823 +1
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rupal-bq
previously approved these changes
Jul 10, 2023
c3cfd1a
2a112c5
to
c3cfd1a
Compare
Yury-Fridlyand
previously approved these changes
Jul 10, 2023
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
c3cfd1a
to
418b5e9
Compare
Yury-Fridlyand
approved these changes
Jul 11, 2023
rupal-bq
approved these changes
Jul 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit a8ecd2f)
vamsimanohar
added a commit
that referenced
this pull request
Jul 11, 2023
…ettings GET API (#1828) * Restrict master key reading from cluster settings API (#1825) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit a8ecd2f) * Fxied DatasourceClusterSettingsIT for 2.x Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
vamsimanohar
pushed a commit
that referenced
this pull request
Jul 11, 2023
…ettings GET API (#1828) * Restrict master key reading from cluster settings API (#1825) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit a8ecd2f) * Fxied DatasourceClusterSettingsIT for 2.x Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Co-authored-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit 98ca9f8)
6 tasks
vamsimanohar
added a commit
that referenced
this pull request
Jul 11, 2023
…ettings GET API (#1828) (#1844) * Restrict master key reading from cluster settings API (#1825) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit a8ecd2f) * Fxied DatasourceClusterSettingsIT for 2.x Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> --------- Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Co-authored-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit 98ca9f8) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 11, 2023
…ject#1825) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 11, 2023
…ject#1825) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to disable master key reading from cluster settings API.
Before the change
GET localhost:9200/_cluster/settings?include_defaults=true
After the change
GET localhost:9200/_cluster/settings?include_defaults=true
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.