Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify OpenSearchIndexScanBuilder (#275) #1738

Merged

Conversation

MaxKsyunz
Copy link
Collaborator

@MaxKsyunz MaxKsyunz commented Jun 14, 2023

Refactoring OpenSearchIndexScanBuilder to address feedback from pagination PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Max Ksyunz <maxk@bitquilltech.com>
@MaxKsyunz MaxKsyunz force-pushed the integ/concrete-scanbuilder branch from 2464d55 to d69b144 Compare June 14, 2023 17:48
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #1738 (2464d55) into main (bd9b180) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2464d55 differs from pull request most recent head d69b144. Consider uploading reports for the commit d69b144 to get more accurate results

@@            Coverage Diff            @@
##               main    #1738   +/-   ##
=========================================
  Coverage     97.30%   97.30%           
- Complexity     4326     4329    +3     
=========================================
  Files           385      385           
  Lines         10807    10811    +4     
  Branches        762      762           
=========================================
+ Hits          10516    10520    +4     
  Misses          284      284           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...search/sql/opensearch/storage/OpenSearchIndex.java 100.00% <100.00%> (ø)
...earch/storage/scan/OpenSearchIndexScanBuilder.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@Yury-Fridlyand Yury-Fridlyand merged commit 29f99aa into opensearch-project:main Jun 14, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the integ/concrete-scanbuilder branch June 14, 2023 22:43
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 14, 2023
Signed-off-by: Max Ksyunz <maxk@bitquilltech.com>
(cherry picked from commit 29f99aa)
MaxKsyunz pushed a commit that referenced this pull request Jun 15, 2023
Signed-off-by: Max Ksyunz <maxk@bitquilltech.com>
(cherry picked from commit 29f99aa)

Co-authored-by: Max Ksyunz <maxk@bitquilltech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants