-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify OpenSearchIndexScanBuilder (#275) #1738
Merged
Yury-Fridlyand
merged 1 commit into
opensearch-project:main
from
Bit-Quill:integ/concrete-scanbuilder
Jun 14, 2023
Merged
Simplify OpenSearchIndexScanBuilder (#275) #1738
Yury-Fridlyand
merged 1 commit into
opensearch-project:main
from
Bit-Quill:integ/concrete-scanbuilder
Jun 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Ksyunz <maxk@bitquilltech.com>
2464d55
to
d69b144
Compare
Codecov Report
@@ Coverage Diff @@
## main #1738 +/- ##
=========================================
Coverage 97.30% 97.30%
- Complexity 4326 4329 +3
=========================================
Files 385 385
Lines 10807 10811 +4
Branches 762 762
=========================================
+ Hits 10516 10520 +4
Misses 284 284
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Yury-Fridlyand
approved these changes
Jun 14, 2023
acarbonetto
approved these changes
Jun 14, 2023
GumpacG
approved these changes
Jun 14, 2023
forestmvey
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring OpenSearchIndexScanBuilder to address feedback from pagination PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.