add flint date type support #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peng Huo <penghuo@gmail.com>
Codecov Report
@@ Coverage Diff @@
## feature/flint #1699 +/- ##
================================================
Coverage 97.19% 97.19%
Complexity 4107 4107
================================================
Files 371 371
Lines 10464 10464
Branches 706 706
================================================
Hits 10170 10170
Misses 287 287
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
dai-chen
approved these changes
Jun 7, 2023
| @@ -86,16 +83,22 @@ object FlintSparkConf { | |||
| val OPTIMIZER_RULE_ENABLED = FlintConfig("spark.flint.optimizer.enabled") | |||
| .doc("Enable Flint optimizer rule for query rewrite with Flint index") | |||
| .createWithDefault("true") | |||
|
|
|||
| val TIME_ZONE = FlintConfig("timeZone") | |||
There was a problem hiding this comment.
Is this a new Flint config or it's same as spark.sql.session.timeZone?
There was a problem hiding this comment.
good point. Yes it is same. remove the timezone and fetch from SQLConf.
|
|
||
| /** | ||
| * Constructs a parser for a given schema that translates a json string to an [[InternalRow]]. | ||
| * copy from spark {@link JacksonParser}. |
There was a problem hiding this comment.
just wonder do we copy this class to tweak something?
There was a problem hiding this comment.
add comments in code about why copy it.
There was a problem hiding this comment.
In Flint Storage, timestamp epoch value is in milliseconds. change parser.getLongValue * 1000000L to parser* .getLongValue * 1000L
Signed-off-by: Peng Huo <penghuo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.