Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Replace non-ASCII characters in code and docs. #1481

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 23cc0f6 from #1365

* Replace non-ASCII characters in code and docs.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Recover unicode characters in grok tests.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Removed some non-English comments.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

* Remove non-English comments from ITs.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 23cc0f6)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 28, 2023 17:30
@codecov-commenter
Copy link

Codecov Report

Merging #1481 (f59b6c8) into 2.x (1aa1861) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##                2.x    #1481   +/-   ##
=========================================
  Coverage     99.96%   99.96%           
  Complexity     2593     2593           
=========================================
  Files           220      220           
  Lines          6205     6205           
  Branches        378      378           
=========================================
  Hits           6203     6203           
  Misses            2        2           
Flag Coverage Δ
sql-engine 99.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen added the maintenance Improves code quality, but not the product label Mar 28, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the backport/backport-1365-to-2.x branch March 29, 2023 20:53
@Yury-Fridlyand
Copy link
Collaborator

Need to rebase

@Yury-Fridlyand
Copy link
Collaborator

Superseded by #1486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improves code quality, but not the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants