Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Added RINT function to V2 engine #1439

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7220cfe from #1433

Added RINT to V2 engine, updated documentation, added unit and IT tests

Signed-off-by: Matthew Wells <matthew.wells@improving.com>
(cherry picked from commit 7220cfe)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 15, 2023 17:42
@codecov-commenter
Copy link

Codecov Report

Merging #1439 (0630379) into 2.x (0b6e581) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##                2.x    #1439   +/-   ##
=========================================
  Coverage     98.38%   98.38%           
- Complexity     3696     3699    +3     
=========================================
  Files           343      343           
  Lines          9115     9120    +5     
  Branches        582      582           
=========================================
+ Hits           8968     8973    +5     
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...h/sql/expression/function/BuiltinFunctionName.java 100.00% <100.00%> (ø)
...ssion/operator/arthmetic/MathematicalFunction.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen added the enhancement New feature or request label Mar 15, 2023
@Yury-Fridlyand Yury-Fridlyand merged commit 014de25 into 2.x Mar 15, 2023
@github-actions github-actions bot deleted the backport/backport-1433-to-2.x branch March 15, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants