Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Interface for DataSource Management #1211

Conversation

vamsimanohar
Copy link
Member

Signed-off-by: vamsi-amazon reddyvam@amazon.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #1211 (0a2259c) into 2.x (13474e3) will decrease coverage by 6.99%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #1211      +/-   ##
============================================
- Coverage     98.32%   91.33%   -7.00%     
+ Complexity     3553     1412    -2141     
============================================
  Files           346      165     -181     
  Lines          8760     4510    -4250     
  Branches        555      386     -169     
============================================
- Hits           8613     4119    -4494     
- Misses          142      333     +191     
- Partials          5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 96.20% <ø> (-2.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/sql/analysis/Analyzer.java
...ensearch/sql/datasource/DataSourceServiceImpl.java
...anner/physical/datasource/DataSourceTableScan.java
...ensearch/sql/expression/ExpressionNodeVisitor.java
...earch/sql/data/utils/NaturalExprValueOrdering.java
...opensearch/sql/exception/QueryEngineException.java
...org/opensearch/sql/expression/env/Environment.java
...earch/sql/expression/window/frame/WindowFrame.java
...pensearch/sql/expression/parse/GrokExpression.java
...on/window/aggregation/AggregateWindowFunction.java
... and 191 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vamsimanohar vamsimanohar force-pushed the datasource-apis-get-post branch 3 times, most recently from 3dab2ae to d844aa7 Compare March 2, 2023 23:46
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
@vamsimanohar vamsimanohar force-pushed the datasource-apis-get-post branch from d844aa7 to a00e434 Compare March 2, 2023 23:52
@vamsimanohar
Copy link
Member Author

Closing in favour of #1427.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants