Remove explicit node version for workbench

Signed-off-by: Joshua Li <joshuali925@gmail.com>
opensearch-project · Apr 22, 2022 · 201d728 · 201d728
1 parent 061456c
commit 201d728
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.github/workflows/sql-workbench-test-and-build-workflow.yml b/.github/workflows/sql-workbench-test-and-build-workflow.yml
@@ -24,10 +24,16 @@ jobs:
           ref: ${{ env.OPENSEARCH_VERSION }}
           path: sql/OpenSearch-Dashboards
 
+      - name: Get node and yarn versions
+        id: versions_step
+        run: |
+          echo "::set-output name=node_version::$(node -p "(require('./OpenSearch-Dashboards/package.json').engines.node).match(/[.0-9]+/)[0]")"
+          echo "::set-output name=yarn_version::$(node -p "(require('./OpenSearch-Dashboards/package.json').engines.yarn).match(/[.0-9]+/)[0]")"
+
       - name: Setup Node
         uses: actions/setup-node@v1
         with:
-          node-version: '14.18.2'
+          node-version: ${{ steps.versions_step.outputs.node_version }}
 
       - name: Move Workbench to Plugins Dir
         run: |

diff --git a/workbench/package.json b/workbench/package.json
@@ -42,10 +42,6 @@
     "tslint-config-prettier": "^1.18.0",
     "tslint-plugin-prettier": "^2.0.1"
   },
-  "engines": {
-    "node": "14.18.2",
-    "yarn": "^1.21.1"
-  },
   "resolutions": {
     "**/@types/node": "10.12.27",
     "@types/react": "16.3.14",