Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ppl allow list bug #512

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

xinyual
Copy link
Collaborator

@xinyual xinyual commented Jan 31, 2025

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: xinyual <xinyual@amazon.com>
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.37%. Comparing base (2b76e3c) to head (4b5e852).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
.../main/java/org/opensearch/agent/tools/PPLTool.java 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #512      +/-   ##
============================================
+ Coverage     81.78%   82.37%   +0.58%     
- Complexity      193      355     +162     
============================================
  Files            11       17       +6     
  Lines           961     1685     +724     
  Branches        137      240     +103     
============================================
+ Hits            786     1388     +602     
- Misses          121      203      +82     
- Partials         54       94      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinyual xinyual merged commit 1e82c0b into opensearch-project:main Jan 31, 2025
8 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2025
Signed-off-by: xinyual <xinyual@amazon.com>
(cherry picked from commit 1e82c0b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2025
Signed-off-by: xinyual <xinyual@amazon.com>
(cherry picked from commit 1e82c0b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
xinyual pushed a commit that referenced this pull request Jan 31, 2025
(cherry picked from commit 1e82c0b)

Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
xinyual pushed a commit that referenced this pull request Jan 31, 2025
(cherry picked from commit 1e82c0b)

Signed-off-by: xinyual <xinyual@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants