-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Improve asynchronous test cases format #3601
[Refactor] Improve asynchronous test cases format #3601
Conversation
Signed-off-by: Peter Nied <petern@amazon.com>
src/integrationTest/java/org/opensearch/security/ResourceFocusedTests.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #3601 +/- ##
=========================================
Coverage 64.90% 64.90%
Complexity 3638 3638
=========================================
Files 284 284
Lines 20616 20619 +3
Branches 3390 3391 +1
=========================================
+ Hits 13381 13383 +2
Misses 5555 5555
- Partials 1680 1681 +1 |
src/integrationTest/java/org/opensearch/security/ResourceFocusedTests.java
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/ResourceFocusedTests.java
Show resolved
Hide resolved
Signed-off-by: Peter Nied <petern@amazon.com>
…port output very much Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
@cwperks here are those improvements from the first PR, let me know what you think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peternied Looks good to me. I left a couple of questions to make sure I understand how the AsyncActions works and the new test log4j property.
src/integrationTest/java/org/opensearch/security/rest/CompressionTests.java
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/rest/CompressionTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me @peternied . Just some nits and question to understand the update to log4j properties
src/integrationTest/java/org/opensearch/test/framework/AsyncActions.java
Outdated
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/test/framework/AsyncActions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Nied <petern@amazon.com>
@cwperks Could you take another look at this change? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3601-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1ad8cf480cd31d2fd10fdb16e974816cb64fe0a8
# Push it to GitHub
git push --set-upstream origin backport/backport-3601-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
…search-project#3601) Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 1ad8cf4)
Manually backported to 2.x because of the apache imports that were using v5 |
Description
Improve asynchronous test cases format
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.