[Build Break] Disable gradlew build cache to ensure most up-to-date dependencies #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndency is used We suspect that we are seeing the snapshot build of opensearch be cached in some circumstances and not cached in others that is creating a mix of build failures that are hard to interpret. Follow up issue to revisit and potentially renable this setting opensearch-project#3185 Signed-off-by: Peter Nied <petern@amazon.com>
cwperks
approved these changes
Aug 15, 2023
|
@cwperks As soon as I have confirmed that the impacted jobs are not broken I am going to push this change directly to main and then do the same with a 2.x backport |
Codecov Report
@@ Coverage Diff @@
## main #3186 +/- ##
=============================================
- Coverage 62.43% 20.93% -41.51%
+ Complexity 3353 914 -2439
=============================================
Files 254 254
Lines 19749 19749
Branches 3334 3334
=============================================
- Hits 12331 4135 -8196
- Misses 5789 15022 +9233
+ Partials 1629 592 -1037 |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-3186-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5e8f12ce5afe95f2f510cddf2a5b2cf50c076a66
# Push it to GitHub
git push --set-upstream origin backport/backport-3186-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.xThen, create a pull request where the |
peternied
added a commit
to peternied/security
that referenced
this pull request
Aug 15, 2023
…t up-to-date dependencies Backport 5e8f12c from opensearch-project#3186. Disable gradlew build cache to ensure most up-to-date dependencies We suspect that we are seeing the snapshot build of opensearch be cached in some circumstances and not cached in others that is creating a mix of build failures that are hard to interpret. Follow up issue to revisit and potentially renable this setting opensearch-project#3185 Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 5e8f12c)
peternied
added a commit
that referenced
this pull request
Aug 15, 2023
…t up-to-date dependencies (#3187) Backport 5e8f12c from #3186. Disable gradlew build cache to ensure most up-to-date dependencies We suspect that we are seeing the snapshot build of opensearch be cached in some circumstances and not cached in others that is creating a mix of build failures that are hard to interpret. Follow up issue to revisit and potentially renable this setting #3185 Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 5e8f12c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable gradlew build cache to ensure most up-to-date dependencies
We suspect that we are seeing the snapshot build of opensearch be cached in some circumstances and not cached in others that is creating a mix of build failures that are hard to interpret.
Follow up issue to revisit and potentially renable this setting #3185
Issues Resolved
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.