Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot: bump com.github.wnameless.json:json-base from 2.4.0 to 2.4.1 #3042

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 24, 2023

Bumps com.github.wnameless.json:json-base from 2.4.0 to 2.4.1.

Commits
  • c43248e [maven-release-plugin] prepare release json-base-2.4.1
  • 3afd62e Upgrade pom
  • f9bc375 Fix typo
  • f39092c Improve #asNumber implementation in OrgJsonValue
  • 8822e1a Add #toJsonString to JsonPrinter
  • c6d9577 Upgrade pom
  • be89de4 [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.github.wnameless.json:json-base](https://github.com/wnameless/json-base) from 2.4.0 to 2.4.1.
- [Changelog](https://github.com/wnameless/json-base/blob/master/release-notes)
- [Commits](wnameless/json-base@json-base-2.4.0...json-base-2.4.1)

---
updated-dependencies:
- dependency-name: com.github.wnameless.json:json-base
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #3042 (11ae398) into main (59e2657) will decrease coverage by 2.17%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3042      +/-   ##
============================================
- Coverage     62.41%   60.24%   -2.17%     
+ Complexity     3379     3272     -107     
============================================
  Files           267      267              
  Lines         19774    19774              
  Branches       3355     3355              
============================================
- Hits          12342    11913     -429     
- Misses         5794     6227     +433     
+ Partials       1638     1634       -4     

see 32 files with indirect coverage changes

@cwperks
Copy link
Member

cwperks commented Jul 27, 2023

How can we fix the code-ql issue?

Error: Workflows triggered by Dependabot on the "push" event run with read-only access.

@peternied
Copy link
Member

@cwperks Looks safe to ignore, it passed on pull request. Maybe we need to change the trigger for code-ql in some cases?

image

@cwperks
Copy link
Member

cwperks commented Jul 27, 2023

@peternied The Squash and merge button appears disabled with the failing check which is preventing this approved PR from merging. Is there a way to enable the button?

@cwperks
Copy link
Member

cwperks commented Jul 27, 2023

Woops nvm, there were other failing checks that were a bit hidden: CI / test (dlicRestApiTest, windows-latest, 11) (push)

@cwperks
Copy link
Member

cwperks commented Jul 27, 2023

Closing in favor of #3062

I have no way to synchronize this branch with main to get the build fixes and have the CI on this PR pass.

@cwperks cwperks closed this Jul 27, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 27, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/com.github.wnameless.json-json-base-2.4.1 branch July 27, 2023 21:42
@cwperks
Copy link
Member

cwperks commented Jul 27, 2023

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 27, 2023

Looks like this PR is closed. If you re-open it, I'll rebase it, as long as no-one else has edited it.

@cwperks
Copy link
Member

cwperks commented Jul 27, 2023

Re-opening

@cwperks
Copy link
Member

cwperks commented Jul 27, 2023

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 27, 2023

Looks like this PR is closed. If you re-open it, I'll rebase it, as long as no-one else has edited it.

@cwperks
Copy link
Member

cwperks commented Jul 27, 2023

The PR cannot be re-opened bc the branch was automatically deleted after closing. I re-opened the manual PR: #3062

Sorry for all the notifications.

cwperks added a commit that referenced this pull request Jul 31, 2023
Manually re-creating dependabot's
[PR](#3042) off of
the latest changes from main which has build fixes.

Is there a way we can open PRs with main at the push of a button?

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants