Security Getting Started page follows Dashboard themes #1538

AMoo-Miki · 2023-08-02T22:45:56Z

Description

public/assets/get_started.svg was an atrocious 18KB asset; cleaned it up to 3.5KB.
Created 2 layers out of get_started.svg.
OSD doesn't provide svgr or anything for inlining SVGs so can't use currentColor; I have put it in the source SVGs anyway in case it is added in the future.
This uses CSS masking.

Issues Resolved

#1527 - Part 1

Check List

New functionality includes testing
New functionality has been documented
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

peternied · 2023-08-02T23:00:13Z

Based on this comment, Please don't merge until I can validate it across relevant browsers. I have marked this pull request a draft, please let us know if we can help, thanks!

AMoo-Miki · 2023-08-02T23:04:03Z

@peternied are these tests supposed to be failing?

peternied · 2023-08-02T23:31:58Z

@RyanL1997 I believe you were looking into these failures, could you link the issue tracking it?

public/apps/configuration/panels/get-started.tsx

Signed-off-by: Miki <miki@amazon.com>

codecov · 2023-08-03T02:02:12Z

Codecov Report

Merging #1538 (5570340) into main (7d34953) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1538   +/-   ##
=======================================
  Coverage   66.06%   66.06%           
=======================================
  Files          93       93           
  Lines        2328     2328           
  Branches      310      310           
=======================================
  Hits         1538     1538           
  Misses        722      722           
  Partials       68       68

Files Changed	Coverage Δ
public/apps/configuration/panels/get-started.tsx	`76.92% <100.00%> (ø)`

cwperks · 2023-08-03T02:10:21Z

@AMoo-Miki The failing checks now are related to compilation issues in the backend security plugin repo. There's an open PR here: opensearch-project/security#3091

There's potentially another issue with some selenium tests and the latest version of FF: #1533 (comment)

Looking into the FF issue now. I will re-run the failed checks when the backend PR is merged and also reply back if any rebasing is needed.

Thank you for the PR. This change looks good to me.

stephen-crawford · 2023-08-03T13:21:50Z

Thank you @AMoo-Miki. This is great! I appreciate all your help with resolving this.

cwperks · 2023-08-03T18:56:25Z

@AMoo-Miki This can be rebased now. The test failures you are seeing were due to an issue with the latest version of the selenium-webdriver: #1540.

RyanL1997

Thanks @AMoo-Miki. I'm re-running the unit tests now.

AMoo-Miki · 2023-08-10T07:48:47Z

Is there anything more I can do for you on this PR?

cwperks · 2023-08-10T17:01:17Z

Nothing from me. This looks good to merge.

Signed-off-by: Miki <miki@amazon.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com> (cherry picked from commit 20ba268)

Signed-off-by: Miki <miki@amazon.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com> Signed-off-by: Sam <samuel.costa@eliatra.com>

* Make the steps diagram honor the theme (#1538) Signed-off-by: Miki <miki@amazon.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com> (cherry picked from commit 20ba268) * Update jwt_auth.test.ts Extend timeout for 2.x line Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> --------- Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>

* Make the steps diagram honor the theme (#1538) Signed-off-by: Miki <miki@amazon.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com> Signed-off-by: Sam <samuel.costa@eliatra.com> * Adding testing info do DEVELOPER_GUIDE.md Signed-off-by: Sam <samuel.costa@eliatra.com> * Minor changes and adding link Signed-off-by: Sam <samuel.costa@eliatra.com> --------- Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Sam <samuel.costa@eliatra.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>

AMoo-Miki requested review from cliu123, cwperks, DarshitChanpura, davidlago, peternied, RyanL1997 and stephen-crawford as code owners August 2, 2023 22:45

peternied marked this pull request as draft August 2, 2023 22:58

AMoo-Miki force-pushed the themed-image branch from 55507ec to 4a76e96 Compare August 2, 2023 23:05

cwperks reviewed Aug 3, 2023

View reviewed changes

public/apps/configuration/panels/get-started.tsx Outdated Show resolved Hide resolved

AMoo-Miki force-pushed the themed-image branch 2 times, most recently from e0569bb to 7bfd411 Compare August 3, 2023 01:01

AMoo-Miki marked this pull request as ready for review August 3, 2023 01:02

AMoo-Miki force-pushed the themed-image branch from 7bfd411 to b7c2a2e Compare August 3, 2023 01:14

Make the steps diagram honor the theme

c9b84bf

Signed-off-by: Miki <miki@amazon.com>

AMoo-Miki force-pushed the themed-image branch from b7c2a2e to c9b84bf Compare August 3, 2023 01:49

cwperks mentioned this pull request Aug 3, 2023

[FEATURE] Mimic the pre-commit hooks from OpenSearch Dashboards #1539

Closed

stephen-crawford approved these changes Aug 3, 2023

View reviewed changes

Merge branch 'main' into themed-image

087b30b

cwperks added the backport 2.x backport to 2.x branch label Aug 4, 2023

RyanL1997 approved these changes Aug 7, 2023

View reviewed changes

Merge branch 'main' into themed-image

5570340

davidlago merged commit 20ba268 into opensearch-project:main Aug 10, 2023

opensearch-trigger-bot bot mentioned this pull request Aug 10, 2023

[Backport 2.x] Make the steps diagram honor the theme #1550

Merged

stephen-crawford mentioned this pull request Aug 14, 2023

Manual backport of #1538 (make steps diagram honor theme) #1551

Closed

3 tasks

peternied changed the title ~~Make the steps diagram honor the theme~~ Security getting started follows Dashboard themes Aug 31, 2023

peternied changed the title ~~Security getting started follows Dashboard themes~~ Security getting started page follows Dashboard themes Aug 31, 2023

peternied changed the title ~~Security getting started page follows Dashboard themes~~ Security Getting Started page follows Dashboard themes Aug 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Security Getting Started page follows Dashboard themes #1538

Security Getting Started page follows Dashboard themes #1538

AMoo-Miki commented Aug 2, 2023 •

edited

Loading

peternied commented Aug 2, 2023

AMoo-Miki commented Aug 2, 2023

peternied commented Aug 2, 2023 •

edited

Loading

codecov bot commented Aug 3, 2023 •

edited

Loading

cwperks commented Aug 3, 2023

stephen-crawford commented Aug 3, 2023

cwperks commented Aug 3, 2023

RyanL1997 left a comment

AMoo-Miki commented Aug 10, 2023

cwperks commented Aug 10, 2023

Security Getting Started page follows Dashboard themes #1538

Security Getting Started page follows Dashboard themes #1538

Conversation

AMoo-Miki commented Aug 2, 2023 • edited Loading

Description

Issues Resolved

Check List

peternied commented Aug 2, 2023

AMoo-Miki commented Aug 2, 2023

peternied commented Aug 2, 2023 • edited Loading

codecov bot commented Aug 3, 2023 • edited Loading

Codecov Report

cwperks commented Aug 3, 2023

stephen-crawford commented Aug 3, 2023

cwperks commented Aug 3, 2023

RyanL1997 left a comment

Choose a reason for hiding this comment

AMoo-Miki commented Aug 10, 2023

cwperks commented Aug 10, 2023

AMoo-Miki commented Aug 2, 2023 •

edited

Loading

peternied commented Aug 2, 2023 •

edited

Loading

codecov bot commented Aug 3, 2023 •

edited

Loading