Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing PR Do Not Merge] Deangular-dashboards Testing #1505

Closed

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Jul 10, 2023

Description

This is the Deangular-dashboards Testing. Since I'm having trouble to pass the saml flaky test in my own fork, I just created this PR as a placeholder to run the tests only. Reviews is not required and it will be closed soon.

Issues Resolved

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1505 (4c8ed0a) into main (32c02c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1505   +/-   ##
=======================================
  Coverage   65.61%   65.61%           
=======================================
  Files          93       93           
  Lines        2309     2309           
  Branches      315      310    -5     
=======================================
  Hits         1515     1515           
  Misses        726      726           
  Partials       68       68           

@RyanL1997
Copy link
Collaborator Author

Confirmed that the saml integration test is breaking. Created a issue: #1506

@RyanL1997 RyanL1997 closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant