Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createmappings api index pattern support #260

Conversation

petardz
Copy link
Contributor

@petardz petardz commented Jan 10, 2023

Signed-off-by: Petar Dzepina petar.dzepina@gmail.com

Description

createmappings api index pattern support

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@petardz petardz requested a review from a team January 10, 2023 22:03
@codecov-commenter
Copy link

Codecov Report

Merging #260 (10640cb) into main (887be34) will decrease coverage by 1.18%.
The diff coverage is 5.29%.

@@             Coverage Diff              @@
##               main     #260      +/-   ##
============================================
- Coverage     38.02%   36.84%   -1.19%     
+ Complexity      887      882       -5     
============================================
  Files           176      179       +3     
  Lines          6795     6957     +162     
  Branches        834      849      +15     
============================================
- Hits           2584     2563      -21     
- Misses         3974     4158     +184     
+ Partials        237      236       -1     
Impacted Files Coverage Δ
...rch/securityanalytics/SecurityAnalyticsPlugin.java 0.00% <0.00%> (ø)
...arch/securityanalytics/action/AckAlertsAction.java 0.00% <ø> (ø)
...search/securityanalytics/alerts/AlertsService.java 21.90% <ø> (ø)
...ch/securityanalytics/findings/FindingsService.java 36.48% <ø> (ø)
...securityanalytics/mapper/IndexTemplateManager.java 0.00% <0.00%> (ø)
...h/securityanalytics/model/CreateMappingResult.java 0.00% <0.00%> (ø)
.../opensearch/securityanalytics/util/IndexUtils.java 38.57% <0.00%> (-3.62%) ⬇️
...ensearch/securityanalytics/util/XContentUtils.java 0.00% <0.00%> (ø)
...search/securityanalytics/mapper/MapperService.java 4.45% <4.25%> (-12.99%) ⬇️
...ensearch/securityanalytics/mapper/MapperUtils.java 28.39% <43.75%> (+0.45%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

getsaurabh02
getsaurabh02 previously approved these changes Jan 11, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@getsaurabh02 getsaurabh02 merged commit d3fb2d9 into opensearch-project:main Jan 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 11, 2023
* createmappings api index pattern support

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* missing tests

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit d3fb2d9)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 11, 2023
* createmappings api index pattern support

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* missing tests

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
(cherry picked from commit d3fb2d9)
sbcd90 pushed a commit that referenced this pull request Jan 11, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
sbcd90 pushed a commit that referenced this pull request Jan 11, 2023
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
eirsep pushed a commit to eirsep/security-analytics that referenced this pull request Apr 3, 2023
* createmappings api index pattern support

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

* missing tests

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>

Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
riysaxen-amzn pushed a commit to riysaxen-amzn/security-analytics that referenced this pull request Mar 25, 2024
* Rebase to push doc level changes on latest main changes (#391)

* Document level alerting dev (opensearch-project#272)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Add last run context to Monitor data model

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* add Update Monitor function

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* fix integ test

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Implemented draft of Finding data model, a new Input type, and some basic unit tests. (opensearch-project#260)

* Implemented draft of Finding data model, and some basic unit tests for it.

Signed-off-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com>

* POC for doc-level-alerting (opensearch-project#277)

Signed-off-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com>

* Add connection to triggers for doc level alerting (opensearch-project#316)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* CRUD APIs integration Tests and validation"conflict resolved" (opensearch-project#362)

Signed-off-by: charliezhangaws <zhanncha@amazon.com>

* Segregate monitor runner logic for separation of concerns (opensearch-project#363)

* Refactor monitor runner logic for separation of concerns and better testability.

Signed-off-by: Saurabh Singh <getsaurabh02@gmail.com>

* Add action and alert flow and findings schema and additional fixes (opensearch-project#381)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Finding Search API (opensearch-project#385)

* Findings search API based on Annie's work

Signed-off-by: Annie Lee <leeyun@amazon.com>

* Fix Search API and add IT tests

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Co-authored-by: Annie Lee <leeyun@amazon.com>

* Fix integ tests and minor issues from doc level changes

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com>
Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com>
Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com>
Co-authored-by: charliezhangaws <zhanncha@amazon.com>
Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com>
Co-authored-by: Annie Lee <leeyun@amazon.com>

* Add Trigger condition resolver which parses and evaluates the Trigger expression. (opensearch-project#405)

Signed-off-by: Saurabh Singh <sisurab@amazon.com>

* percolate query implementation in doc-level alerting (opensearch-project#399)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

* Finding Index rollover (opensearch-project#408)

* Finding Index rollover

Signed-off-by: jiahe zhang <zhanncha@amazon.com>

* Apply fixes to make rollover work

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Co-authored-by: jiahe zhang <zhanncha@amazon.com>

Co-authored-by: Annie Lee <71157062+leeyun-amzn@users.noreply.github.com>
Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
Co-authored-by: AWSHurneyt <79280347+AWSHurneyt@users.noreply.github.com>
Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com>
Co-authored-by: charliezhangaws <zhanncha@amazon.com>
Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com>
Co-authored-by: Annie Lee <leeyun@amazon.com>
Co-authored-by: Saurabh Singh <sisurab@amazon.com>
Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants