Added catch for unexpected inputs. #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
|
The security tests have been failing for unrelated reasons. Will investigate those test failures separately. |
eirsep
approved these changes
Jan 8, 2025
engechas
approved these changes
Jan 8, 2025
| @@ -36,7 +38,7 @@ static Source readFrom(StreamInput sin) throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| static Source parse(XContentParser xcp) throws IOException { | |||
| public static Source parse(XContentParser xcp) throws IOException { | |||
There was a problem hiding this comment.
Nit: This can remain package-private since the test class is in the same package
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit dca74ce) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit dca74ce) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit dca74ce) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit dca74ce) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit dca74ce) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
added a commit
that referenced
this pull request
Jan 28, 2025
(cherry picked from commit dca74ce) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added catch for unexpected inputs.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.