[Backport 2.17] Backport #1335 to 2.x #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add null check while adding fetched iocs into per-indicator-type map (#1335) * add null check while adding fetched iocs into per-indicator-type map Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * adds tests verifying monitor configured on multiple indicator types Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix constructor for 2.x Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit 01d9011)
sbcd90
approved these changes
Oct 3, 2024
eirsep
approved these changes
Oct 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.17 #1341 +/- ##
============================================
- Coverage 68.75% 68.69% -0.06%
- Complexity 3583 3584 +1
============================================
Files 404 404
Lines 20038 20038
Branches 2042 2042
============================================
- Hits 13777 13766 -11
- Misses 5240 5255 +15
+ Partials 1021 1017 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 01d9011 from #1339