Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.16] Fix S3 validation errors not caught by action listener #1266

Merged
merged 1 commit into from
Aug 21, 2024
Merged

[Backport 2.16] Fix S3 validation errors not caught by action listener #1266

merged 1 commit into from
Aug 21, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2e0ed56 from #1257.

@github-actions
Fix S3 validation errors not caught by action listener (#1257)
f48ecaf 
* catch errors and fail action listener

Signed-off-by: Joanne Wang <jowg@amazon.com>

* add test to validate behavior

Signed-off-by: Joanne Wang <jowg@amazon.com>

---------

Signed-off-by: Joanne Wang <jowg@amazon.com>
(cherry picked from commit 2e0ed56)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.87%. Comparing base (4be8ce2) to head (f48ecaf).
Report is 2 commits behind head on 2.16.

Files Patch % Lines
...curityanalytics/services/STIX2IOCFetchService.java 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               2.16    #1266      +/-   ##
============================================
+ Coverage     68.73%   68.87%   +0.13%     
- Complexity     3560     3565       +5     
============================================
  Files           404      404              
  Lines         19897    19901       +4     
  Branches       2037     2037              
============================================
+ Hits          13676    13706      +30     
+ Misses         5209     5178      -31     
- Partials       1012     1017       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jowg-amazon jowg-amazon merged commit 09f8ced into 2.16 Aug 21, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AWSHurneyt AWSHurneyt AWSHurneyt approved these changes

@jowg-amazon jowg-amazon jowg-amazon approved these changes

@amsiglan amsiglan Awaiting requested review from amsiglan amsiglan is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@eirsep eirsep Awaiting requested review from eirsep eirsep is a code owner

@engechas engechas Awaiting requested review from engechas engechas is a code owner

@goyamegh goyamegh Awaiting requested review from goyamegh goyamegh is a code owner

@riysaxen-amzn riysaxen-amzn Awaiting requested review from riysaxen-amzn riysaxen-amzn is a code owner

Assignees
No one assigned
Labels
autocut
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AWSHurneyt @jowg-amazon