Fix snapshot build using OpenSearch 1.1. #53
Conversation
e4f37c4 to
e657415
Compare
Signed-off-by: dblock <dblock@amazon.com>
e657415 to
af89e4d
Compare
14d2ec8 to
6bb5f77
Compare
Signed-off-by: dblock <dblock@amazon.com>
6bb5f77 to
099c81b
Compare
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
=========================================
Coverage 72.18% 72.18%
Complexity 356 356
=========================================
Files 44 44
Lines 2509 2509
Branches 160 160
=========================================
Hits 1811 1811
Misses 592 592
Partials 106 106 Continue to review full report at Codecov.
|
build.gradle
Outdated
| } | ||
| exec { | ||
| def licenseDir = "$projectDir/licenses" | ||
| workingDir("$licenseDir") | ||
| commandLine 'rm', "-f", "performanceanalyzer-rca-1.0.0.0.jar.sha1" | ||
| commandLine 'rm', "-f", "performanceanalyzer-rca-${project.version}.jar.sha1" |
There was a problem hiding this comment.
version or opensearch.version?
| working-directory: ./tmp/performance-analyzer | ||
| run: | | ||
| ./gradlew build -Dperformance-analyzer-rca.build=true \ | ||
| -Dperformance-analyzer-rca.repo="https://github.com/dblock/performance-analyzer-rca.git" \ |
There was a problem hiding this comment.
Can we change this to the main repo before merging?
There was a problem hiding this comment.
Sure, but it will break the build. So, we can't. And if I merge opensearch-project/performance-analyzer-rca#55 it's the same problem for that PR. I think the safe thing to do is to merge this PR and opensearch-project/performance-analyzer-rca#55 and then go and change on both sides carefully (which I will do).
Signed-off-by: dblock <dblock@amazon.com>
* Revert back 1.0.1 upgrade * Fix snapshot build using OpenSearch 1.1. (#53) * Use performance-analyzer-rca main branch. (#54) Signed-off-by: dblock <dblock@amazon.com> * Upgrade to 1.0.1 version Signed-off-by: Sruti Parthiban <partsrut@amazon.com> Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
Signed-off-by: dblock dblock@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
There's a circular dependency described in #50, so opensearch-project/performance-analyzer-rca#55 is needed. Once this is merged I'll switch references to my fork that contains this code.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.