Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPDX license identifier #3

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Add SPDX license identifier #3

merged 2 commits into from
Apr 19, 2021

Conversation

hxiao608
Copy link
Contributor

@hxiao608 hxiao608 commented Apr 19, 2021 •
edited
Loading

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Adding SDPX license identifier to files with existing ALv2 header

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@hxiao608 hxiao608 requested review from kkhatua, sruti1312, ricardolstephen and yujias0706 and removed request for ricardolstephen April 19, 2021 20:39
kkhatua
kkhatua approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@kkhatua kkhatua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@hxiao608 hxiao608 merged commit 823a236 into main Apr 19, 2021
@sruti1312 sruti1312 deleted the os-plugin-update branch June 23, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkhatua kkhatua kkhatua approved these changes

@jotok jotok jotok approved these changes

@dblock dblock dblock approved these changes

@sruti1312 sruti1312 Awaiting requested review from sruti1312

@yujias0706 yujias0706 Awaiting requested review from yujias0706

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hxiao608 @dblock @jotok @kkhatua