Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom plugin to publish zips to local repo #229

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

sgup432
Copy link
Contributor

@sgup432 sgup432 commented Jun 13, 2022

Signed-off-by: Sagar Upadhyaya sagar.upadhyaya.121@amazon.com

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#202

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context

Testing - Verified by running publishPluginZipPublicationToZipStagingRepository task that zip is being generated in local maven repo.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@amazon.com>
@sgup432 sgup432 requested review from a team, dzane17, kkhatua and sruti1312 June 13, 2022 22:53
@codecov-commenter
Copy link

Codecov Report

Merging #229 (ad885c2) into main (ec2e5b9) will increase coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #229      +/-   ##
============================================
+ Coverage     71.68%   71.84%   +0.15%     
- Complexity      367      368       +1     
============================================
  Files            44       44              
  Lines          2522     2522              
  Branches        171      171              
============================================
+ Hits           1808     1812       +4     
+ Misses          601      598       -3     
+ Partials        113      112       -1     
Impacted Files Coverage Δ
...ormanceanalyzer/writer/EventLogQueueProcessor.java 60.71% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec2e5b9...ad885c2. Read the comment docs.

@sgup432 sgup432 merged commit 9e553c5 into opensearch-project:main Jun 13, 2022
sgup432 added a commit to sgup432/performance-analyzer that referenced this pull request Jun 13, 2022
…t#229)

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

Co-authored-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
sgup432 added a commit that referenced this pull request Jun 14, 2022
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

Co-authored-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants