Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSearch fork changes #1

Merged
merged 2 commits into from
Apr 16, 2021
Merged

OpenSearch fork changes #1

merged 2 commits into from
Apr 16, 2021

Conversation

sruti1312
Copy link
Contributor

Issue #, if available:

Description of changes:

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

dblock
dblock previously requested changes Apr 16, 2021
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, lots of changes.

Look for leftover opendistro's. Consider fixing CI.

packaging/deb/postrm Show resolved Hide resolved
packaging/performance-analyzer-agent-cli Show resolved Hide resolved
echo "-Djdk.attach.allowAttachSelf=true" >> /etc/elasticsearch/jvm.options
echo "-Djava.security.policy=file:///usr/share/elasticsearch/plugins/opendistro-performance-analyzer/pa_config/es_security.policy" >> /etc/elasticsearch/jvm.options
echo >> /etc/opensearch/jvm.options
echo '## OpenDistro Performance Analyzer' >> /etc/opensearch/jvm.options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenDistro -> OpenSearch

Copy link
Member

@kkhatua kkhatua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@kkhatua
Copy link
Member

kkhatua commented Apr 16, 2021

Phew, lots of changes.

Look for leftover opendistro's. Consider fixing CI.

Migration of namespace and equivalent code elements will be done in the future, subject to a review of the impact on API changes.

@kkhatua kkhatua dismissed dblock’s stale review April 16, 2021 21:53

Changing namespace from 'opendistro' to 'opensearch' will be a future exercise.

@kkhatua kkhatua merged commit c345af1 into main Apr 16, 2021
@sruti1312 sruti1312 deleted the es-to-os branch April 26, 2021 19:05
sruti1312 pushed a commit that referenced this pull request Jun 23, 2021
Rebranded to OpenSearch (Ver1)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 17, 2024
peterzhuamazon pushed a commit that referenced this pull request Jun 17, 2024
…#671) (#672)

(cherry picked from commit 9cb092f)

Co-authored-by: DevJhaAbhishek <137988638+DevJhaAbhishek@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 17, 2024
peterzhuamazon pushed a commit that referenced this pull request Jun 17, 2024
…#671) (#673)

(cherry picked from commit 9cb092f)

Co-authored-by: DevJhaAbhishek <137988638+DevJhaAbhishek@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants