Add DCO workflow and fix failing IT

Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
opensearch-project · Nov 2, 2021 · a79a451 · a79a451
1 parent 184caae
commit a79a451
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 8 deletions.
diff --git a/.github/workflows/dco.yml b/.github/workflows/dco.yml
@@ -0,0 +1,18 @@
+name: Developer Certificate of Origin Check
+
+on: [pull_request]
+
+jobs:
+  check:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Get PR Commits
+        id: 'get-pr-commits'
+        uses: tim-actions/get-pr-commits@v1.1.0
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+      - name: DCO Check
+        uses: tim-actions/dco@v1.1.0
+        with:
+          commits: ${{ steps.get-pr-commits.outputs.commits }}
diff --git a/src/test/java/org/opensearch/performanceanalyzer/ConfigOverridesIT.java b/src/test/java/org/opensearch/performanceanalyzer/ConfigOverridesIT.java
@@ -58,16 +58,16 @@ public class ConfigOverridesIT extends PerformanceAnalyzerIntegTestBase {
 
     @Test
     public void testSimpleOverride() throws Exception {
-        testSimpleOverride(CONFIG_OVERRIDES_ENDPOINT);
+        testSimpleOverride(RestConfig.PA_BASE_URI, CONFIG_OVERRIDES_ENDPOINT);
     }
 
     @Test
     public void testLegacySimpleOverride() throws Exception {
-        testSimpleOverride(LEGACY_OPENDISTRO_CONFIG_OVERRIDES_ENDPOINT);
+        testSimpleOverride(RestConfig.LEGACY_PA_BASE_URI, LEGACY_OPENDISTRO_CONFIG_OVERRIDES_ENDPOINT);
     }
 
-    public void testSimpleOverride(String configOverridesEndpoint) throws Exception {
-        ensurePaAndRcaEnabled(configOverridesEndpoint);
+    public void testSimpleOverride(String paBaseUri, String configOverridesEndpoint) throws Exception {
+        ensurePaAndRcaEnabled(paBaseUri);
         final ConfigOverrides overrides =
                 getOverrides(
                         Arrays.asList(HOT_SHARD_RCA, HOT_NODE_CLUSTER_RCA),
@@ -106,16 +106,16 @@ public void testSimpleOverride(String configOverridesEndpoint) throws Exception
 
     @Test
     public void testCompositeOverrides() throws Exception {
-        testCompositeOverrides(CONFIG_OVERRIDES_ENDPOINT);
+        testCompositeOverrides(RestConfig.PA_BASE_URI, CONFIG_OVERRIDES_ENDPOINT);
     }
 
     @Test
     public void testLegacyCompositeOverrides() throws Exception {
-        testCompositeOverrides(LEGACY_OPENDISTRO_CONFIG_OVERRIDES_ENDPOINT);
+        testCompositeOverrides(RestConfig.LEGACY_PA_BASE_URI, LEGACY_OPENDISTRO_CONFIG_OVERRIDES_ENDPOINT);
     }
 
-    public void testCompositeOverrides(String configOverridesEndpoint) throws Exception {
-        ensurePaAndRcaEnabled(configOverridesEndpoint);
+    public void testCompositeOverrides(String paBaseUri, String configOverridesEndpoint) throws Exception {
+        ensurePaAndRcaEnabled(paBaseUri);
 
         final ConfigOverrides initialOverrides =
                 getOverrides(