Remove emitting the entry key with the METRICS_WRITE_ERROR metric #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
kjoseph07
approved these changes
Sep 20, 2021
sruti1312
added a commit
that referenced
this pull request
Sep 23, 2021
* Remove emitting the entry key with the METRICS_WRITE_ERROR metric (#71) Signed-off-by: Sruti Parthiban <partsrut@amazon.com> * Update commons-io version Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
sruti1312
added a commit
that referenced
this pull request
Sep 27, 2021
* Remove emitting the entry key with the METRICS_WRITE_ERROR metric (#71) Signed-off-by: Sruti Parthiban <partsrut@amazon.com> * Update commons-io version (#73) Signed-off-by: Sruti Parthiban <partsrut@amazon.com> * AdmissionControl Split RCA (#69) Signed-off-by: Mital Awachat <awachatm@amazon.com> Co-authored-by: Mital Awachat <awachatm@amazon.com> Co-authored-by: Sruti Parthiban <partsrut@amazon.com> Co-authored-by: Mital Awachat <awachatm@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sruti Parthiban partsrut@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
There is an increase in cardinality of metrics due to a recently added metric
MetricsWriteErrorwhich always has unique dimension value for field Instance as it includes timestamp and the threadId. This value was emitted continuously due a known bug causing the pa.plugin.stats file to grow really large. This bug is currently fixed inmainDescribe the solution you are proposing
Alter to remove emitting the entry key with the
METRICS_WRITE_ERRORmetric.Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.