Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backward compatible resource names to RcaController #19

Merged
merged 1 commit into from
May 25, 2021

Conversation

jotok
Copy link
Contributor

@jotok jotok commented May 25, 2021

Signed-off-by: Joshua Tokle joshtok@amazon.com

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
The previous backward compatibility PR (#18) didn't update RcaController.

Describe the solution you are proposing
Add backward compatibility to resources defined in RcaController.

[root@7616e7370051 opensearch]# curl http://localhost:9600/_opendistro/_performanceanalyzer/rca -XGET
{"OldGenReclamationRca":[{"rca_name":"OldGenReclamationRca","timestamp":1621960502692,"state":"unknown"}],"HighOldGenOccupancyRca":[{"rca_name":"HighOldGenOccupancyRca","timestamp":1621960502693,"state":"healthy"}],"QueueRejectionRca":[{"rca_name":"QueueRejectionRca","timestamp":1621960457976,"state":"healthy"}],"FieldDataCacheRca":[{"rca_name":"FieldDataCacheRca","timestamp":1621960458053,"state":"healthy"}],"HighHeapUsageYoungGenRca":[{"rca_name":"HighHeapUsageYoungGenRca","timestamp":1621960457751,"state":"healthy"}],"HighHeapUsageOldGenRca":[{"rca_name":"HighHeapUsageOldGenRca","timestamp":1621960457758,"state":"healthy"}],"ShardRequestCacheRca":[{"rca_name":"ShardRequestCacheRca","timestamp":1621960458048,"state":"healthy"}],"HighCpuRca":[{"rca_name":"HighCpuRca","timestamp":1621960457754,"state":"healthy"}],"HotShardRca":[{"rca_name":"HotShardRca","timestamp":1621960458133,"state":"healthy"}],"FieldDataCacheClusterRca":[{"rca_name":"FieldDataCacheClusterRca","timestamp":1621960457869,"state":"healthy"}],"QueueRejectionClusterRca":[{"rca_name":"QueueRejectionClusterRca","timestamp":1621960457869,"state":"healthy"}],"ShardRequestCacheClusterRca":[{"rca_name":"ShardRequestCacheClusterRca","timestamp":1621960457876,"state":"healthy"}],"HotNodeRca":[{"rca_name":"HotNodeRca","timestamp":1621960458163,"state":"healthy"}],"HighHeapUsageClusterRca":[{"rca_name":"HighHeapUsageClusterRca","timestamp":1621960457974,"state":"healthy"}]}

[root@7616e7370051 opensearch]# curl http://localhost:9600/_plugins/_performanceanalyzer/rca -XGET
{"OldGenReclamationRca":[{"rca_name":"OldGenReclamationRca","timestamp":1621960512692,"state":"unknown"}],"HighOldGenOccupancyRca":[{"rca_name":"HighOldGenOccupancyRca","timestamp":1621960512693,"state":"healthy"}],"QueueRejectionRca":[{"rca_name":"QueueRejectionRca","timestamp":1621960457976,"state":"healthy"}],"FieldDataCacheRca":[{"rca_name":"FieldDataCacheRca","timestamp":1621960458053,"state":"healthy"}],"HighHeapUsageYoungGenRca":[{"rca_name":"HighHeapUsageYoungGenRca","timestamp":1621960457751,"state":"healthy"}],"HighHeapUsageOldGenRca":[{"rca_name":"HighHeapUsageOldGenRca","timestamp":1621960457758,"state":"healthy"}],"ShardRequestCacheRca":[{"rca_name":"ShardRequestCacheRca","timestamp":1621960458048,"state":"healthy"}],"HighCpuRca":[{"rca_name":"HighCpuRca","timestamp":1621960457754,"state":"healthy"}],"HotShardRca":[{"rca_name":"HotShardRca","timestamp":1621960458133,"state":"healthy"}],"FieldDataCacheClusterRca":[{"rca_name":"FieldDataCacheClusterRca","timestamp":1621960457869,"state":"healthy"}],"QueueRejectionClusterRca":[{"rca_name":"QueueRejectionClusterRca","timestamp":1621960457869,"state":"healthy"}],"ShardRequestCacheClusterRca":[{"rca_name":"ShardRequestCacheClusterRca","timestamp":1621960457876,"state":"healthy"}],"HotNodeRca":[{"rca_name":"HotNodeRca","timestamp":1621960458163,"state":"healthy"}],"HighHeapUsageClusterRca":[{"rca_name":"HighHeapUsageClusterRca","timestamp":1621960457974,"state":"healthy"}]}

[root@7616e7370051 opensearch]# curl http://localhost:9600/_plugins/_performanceanalyzer/actions -XGET
{"LastSuggestedActionSet":[]}

[root@7616e7370051 opensearch]# curl http://localhost:9600/_opendistro/_performanceanalyzer/actions -XGET
{"LastSuggestedActionSet":[]}

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Tokle <joshtok@amazon.com>
@jotok jotok requested a review from sruti1312 May 25, 2021 01:45
@sruti1312
Copy link
Contributor

sruti1312 commented May 25, 2021

Build is failing because of a failing test. We have retries enabled and this test is passing in next retry, but still leading to test failure. We need to fix this issue where build checks all the iterations instead of just the last one.

548 tests completed, 1 failed
FAILURE: Executed 548 tests in 3h 24m (1 failed)
org.opensearch.performanceanalyzer.rca.integTests.tests.jvm.young_gen.YoungGenMissingMetricsTest

  Test testMissingHeapMetrics PASSED (3m 14s)

java.lang.Class

  Test testDataNodeMissingGcMetrics FAILED

  java.util.concurrent.TimeoutException: waitFor timed out before task evaluated to true
org.opensearch.performanceanalyzer.rca.integTests.tests.jvm.young_gen.YoungGenMissingMetricsTest

  Test testMissingHeapMetrics PASSED (3m 14s)
  Test testDataNodeMissingGcMetrics PASSED (3m 10s)

Create an issue to track and fix this.
#20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants