Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace references to /_opendistro with /_plugins #16

Merged
merged 3 commits into from
May 21, 2021

Conversation

jotok
Copy link
Contributor

@jotok jotok commented May 21, 2021

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Updating calls to the Performance Analyzer plugin API to follow the new /_plugins naming convention.

Describe the solution you are proposing
RCA behavior should be unchanged.

Describe alternatives you've considered
This is a required change to follow new OpenSearch guidelines.

Additional context
https://github.com/opensearch-project/opensearch-plugins/blob/main/UPGRADING.md#settings-backwards-compatibility

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member

dblock commented May 21, 2021

This all executes client-side, right? There's nothing server-side that needs to preserve backward compatibility here?

README.md Outdated Show resolved Hide resolved
@jotok
Copy link
Contributor Author

jotok commented May 21, 2021

@dblock The RCA app creates a server that responds to the requests on port 9600, which means we do need to make a change for backward compatibility. We will follow up this PR with one that adds backward compatibility for the /_opendistro resource. We want to merge this PR first to unblock work on perftop.

@hxiao608 hxiao608 self-requested a review May 21, 2021 22:50
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sruti1312 sruti1312 merged commit 30b53ae into main May 21, 2021
@sruti1312 sruti1312 deleted the update-rest-resource-names branch May 21, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants