New trendline ppl command (SMA only) #833

salyh · 2024-10-29T21:09:24Z

Description

New trendline ppl command (SMA only). For WMA see #831

Related Issues

Check List

Updated documentation (docs/ppl-lang/README.md)
Implemented unit tests
Implemented tests for combination with other commands
New added source code should include a copyright header
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

YANG-DB

Please also add command to the README, a dedicated page for this command with a link to the dedicated doc and examples in the examples page

ppl-spark-integration/src/main/java/org/opensearch/sql/ppl/parser/AstBuilder.java

ppl-spark-integration/src/main/java/org/opensearch/sql/ast/tree/Trendline.java

ppl-spark-integration/src/main/antlr4/OpenSearchPPLParser.g4

ppl-spark-integration/src/main/java/org/opensearch/sql/ppl/CatalystQueryPlanVisitor.java

ppl-spark-integration/src/main/antlr4/OpenSearchPPLParser.g4

YANG-DB

@salyh plz add logical plan test in the relevant folder
And also plz add a test with no alias example (for logical and actual queries)

salyh · 2024-10-30T18:29:07Z

@salyh plz add logical plan test in the relevant folder And also plz add a test with no alias example (for logical and actual queries)

done

docs/ppl-lang/ppl-trendline-command.md

ppl-spark-integration/src/main/java/org/opensearch/sql/ast/tree/Trendline.java

ppl-spark-integration/src/main/java/org/opensearch/sql/ppl/parser/AstBuilder.java

ppl-spark-integration/src/main/java/org/opensearch/sql/ppl/utils/TrendlineStrategy.java

YANG-DB · 2024-10-30T21:52:33Z

@jduo thanks for u'r feedback - really appreciated !

LantaoJin

https://github.com/opensearch-project/opensearch-spark/pull/833/files#r1823633566

To save time, you can ignore the plan assertion and just check the return data matching the expectation. Many thanks! Here is an example for chaining trendline:
| source = $testTable | eval age_1 = age, age_2 = age | trendline sort - age_1 sma(3, age_1) | trendline sort + age_2 sma(3, age_2)

LantaoJin · 2024-10-31T02:25:50Z

Another question is whether the sort field can be different from the calculated field? If the answer is no, please throw out an exception for | source = $testTable | trendline sort + name sma(3, age).
If the answer is yes, what is the special semantic for above query?

But this sort keyword in trendline still seems an one way door design, deep diving we could get another case:
| source = $testTable | eval age_alias = age | trendline sort + age_alias sma(3, age).
Will this query fail either? There is no semantic problem IMO. That's why I comment and suggest here.

However, I can give an approval to unblock releasing this as is for now as long as above chaining case works.

salyh · 2024-10-31T07:57:59Z

https://github.com/opensearch-project/opensearch-spark/pull/833/files#r1823633566

To save time, you can ignore the plan assertion and just check the return data matching the expectation. Many thanks! Here is an example for chaining trendline: | source = $testTable | eval age_1 = age, age_2 = age | trendline sort - age_1 sma(3, age_1) | trendline sort + age_2 sma(3, age_2)

@LantaoJin @YANG-DB IT chaining test added

Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com>

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com>

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

solved as shown here -

opensearch-spark/integ-test/src/integration/scala/org/opensearch/flint/spark/ppl/FlintSparkPPLTrendlineITSuite.scala

Line 217 in ffcc918

test("test trendline sma command chaining") {

YANG-DB · 2024-11-01T19:22:27Z

Another question is whether the sort field can be different from the calculated field? If the answer is no, please throw out an exception for | source = $testTable | trendline sort + name sma(3, age). If the answer is yes, what is the special semantic for above query?

But this sort keyword in trendline still seems an one way door design, deep diving we could get another case: | source = $testTable | eval age_alias = age | trendline sort + age_alias sma(3, age). Will this query fail either? There is no semantic problem IMO. That's why I comment and suggest here.

However, I can give an approval to unblock releasing this as is for now as long as above chaining case works.

@LantaoJin I'm approving the PR for merge as this issue was addresses here

* update antlr grammar for (future) P1 command syntax Signed-off-by: YANGDB <yang.db.dev@gmail.com> * add trendline command Signed-off-by: YANGDB <yang.db.dev@gmail.com> * add expand command Signed-off-by: YANGDB <yang.db.dev@gmail.com> * add geoip command Signed-off-by: YANGDB <yang.db.dev@gmail.com> * PPl `flatten` command (#784) * The flatten command implemented Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> * The flatten command integration tests were extended with additional checks for logical plans. Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> * flatten, added more tests related to plan translation and integration tests Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> * Flatten command added to command names list. Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> --------- Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> * Extract source table names from mv query (#854) * add sourceTables to MV index metadata properties Signed-off-by: Sean Kao <seankao@amazon.com> * parse source tables from mv query Signed-off-by: Sean Kao <seankao@amazon.com> * test cases for parse source tables from mv query Signed-off-by: Sean Kao <seankao@amazon.com> * use constant for metadata cache version Signed-off-by: Sean Kao <seankao@amazon.com> * write source tables to metadata cache Signed-off-by: Sean Kao <seankao@amazon.com> * address comment Signed-off-by: Sean Kao <seankao@amazon.com> * generate source tables for old mv without new prop Signed-off-by: Sean Kao <seankao@amazon.com> * syntax fix Signed-off-by: Sean Kao <seankao@amazon.com> --------- Signed-off-by: Sean Kao <seankao@amazon.com> * Fallback to internal scheduler when index creation failed (#850) * Fallback to internal scheduler when index creation failed Signed-off-by: Louis Chu <clingzhi@amazon.com> * Fix IT Signed-off-by: Louis Chu <clingzhi@amazon.com> * Fix IOException Signed-off-by: Louis Chu <clingzhi@amazon.com> --------- Signed-off-by: Louis Chu <clingzhi@amazon.com> * New trendline ppl command (SMA only) (#833) * WIP trendline command Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * wip Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * trendline supports sorting Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * run scalafmtAll Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * return null when there are too few data points Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * sbt scalafmtAll Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * Remove WMA references Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * trendline - sortByField as Optional<Field> Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * introduce TrendlineStrategy Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * keywordsCanBeId -> replace SMA with trendlineType Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * handle trendline alias as qualifiedName instead of fieldExpression Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * Add docs Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Make alias optional Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Adapt tests for optional alias Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Adden logical plan unittests Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Add missing license headers Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Fix docs Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * numberOfDataPoints must be 1 or greater Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Rename TrendlineStrategy to TrendlineCatalystUtils Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Validate TrendlineType early and pass around enum type Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Add trendline chaining test Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Fix compile errors Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Fix imports Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Fix imports Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> --------- Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> Co-authored-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * update iplocation antlr Signed-off-by: YANGDB <yang.db.dev@gmail.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> Signed-off-by: Sean Kao <seankao@amazon.com> Signed-off-by: Louis Chu <clingzhi@amazon.com> Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> Co-authored-by: lukasz-soszynski-eliatra <110241464+lukasz-soszynski-eliatra@users.noreply.github.com> Co-authored-by: Sean Kao <seankao@amazon.com> Co-authored-by: Louis Chu <clingzhi@amazon.com> Co-authored-by: Hendrik Saly <hendrik.saly@eliatra.com> Co-authored-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com>

* update antlr grammar for (future) P1 command syntax Signed-off-by: YANGDB <yang.db.dev@gmail.com> * add trendline command Signed-off-by: YANGDB <yang.db.dev@gmail.com> * add expand command Signed-off-by: YANGDB <yang.db.dev@gmail.com> * add geoip command Signed-off-by: YANGDB <yang.db.dev@gmail.com> * PPl `flatten` command (#784) * The flatten command implemented Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> * The flatten command integration tests were extended with additional checks for logical plans. Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> * flatten, added more tests related to plan translation and integration tests Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> * Flatten command added to command names list. Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> --------- Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> * Extract source table names from mv query (#854) * add sourceTables to MV index metadata properties Signed-off-by: Sean Kao <seankao@amazon.com> * parse source tables from mv query Signed-off-by: Sean Kao <seankao@amazon.com> * test cases for parse source tables from mv query Signed-off-by: Sean Kao <seankao@amazon.com> * use constant for metadata cache version Signed-off-by: Sean Kao <seankao@amazon.com> * write source tables to metadata cache Signed-off-by: Sean Kao <seankao@amazon.com> * address comment Signed-off-by: Sean Kao <seankao@amazon.com> * generate source tables for old mv without new prop Signed-off-by: Sean Kao <seankao@amazon.com> * syntax fix Signed-off-by: Sean Kao <seankao@amazon.com> --------- Signed-off-by: Sean Kao <seankao@amazon.com> * Fallback to internal scheduler when index creation failed (#850) * Fallback to internal scheduler when index creation failed Signed-off-by: Louis Chu <clingzhi@amazon.com> * Fix IT Signed-off-by: Louis Chu <clingzhi@amazon.com> * Fix IOException Signed-off-by: Louis Chu <clingzhi@amazon.com> --------- Signed-off-by: Louis Chu <clingzhi@amazon.com> * New trendline ppl command (SMA only) (#833) * WIP trendline command Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * wip Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * trendline supports sorting Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * run scalafmtAll Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * return null when there are too few data points Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * sbt scalafmtAll Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * Remove WMA references Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * trendline - sortByField as Optional<Field> Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * introduce TrendlineStrategy Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * keywordsCanBeId -> replace SMA with trendlineType Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * handle trendline alias as qualifiedName instead of fieldExpression Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * Add docs Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Make alias optional Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Adapt tests for optional alias Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Adden logical plan unittests Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Add missing license headers Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Fix docs Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * numberOfDataPoints must be 1 or greater Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Rename TrendlineStrategy to TrendlineCatalystUtils Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Validate TrendlineType early and pass around enum type Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Add trendline chaining test Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Fix compile errors Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Fix imports Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Fix imports Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> --------- Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> Co-authored-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * update iplocation antlr Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update scala fmt style Signed-off-by: YANGDB <yang.db.dev@gmail.com> * `cidrmatch` ppl command add logical tests and docs (#865) * update logical tests and docs Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update scala fmt style Signed-off-by: YANGDB <yang.db.dev@gmail.com> * fix type error Signed-off-by: YANGDB <yang.db.dev@gmail.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Support Lambda and add related array functions (#864) * json function enhancement Signed-off-by: Heng Qian <qianheng@amazon.com> * Add JavaToScalaTransformer Signed-off-by: Heng Qian <qianheng@amazon.com> * Apply scalafmtAll Signed-off-by: Heng Qian <qianheng@amazon.com> * Address comments Signed-off-by: Heng Qian <qianheng@amazon.com> * Add IT and change to use the same function name as spark Signed-off-by: Heng Qian <qianheng@amazon.com> * Address comments Signed-off-by: Heng Qian <qianheng@amazon.com> * Add document and separate lambda functions from json functions Signed-off-by: Heng Qian <qianheng@amazon.com> * Add lambda functions transform and reduce Signed-off-by: Heng Qian <qianheng@amazon.com> * polish lambda function document Signed-off-by: Heng Qian <qianheng@amazon.com> * polish lambda function document Signed-off-by: Heng Qian <qianheng@amazon.com> * Minor fix Signed-off-by: Heng Qian <qianheng@amazon.com> * Minor change to polish the documents Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com> Signed-off-by: Sean Kao <seankao@amazon.com> Signed-off-by: Louis Chu <clingzhi@amazon.com> Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> Signed-off-by: Heng Qian <qianheng@amazon.com> Co-authored-by: lukasz-soszynski-eliatra <110241464+lukasz-soszynski-eliatra@users.noreply.github.com> Co-authored-by: Sean Kao <seankao@amazon.com> Co-authored-by: Louis Chu <clingzhi@amazon.com> Co-authored-by: Hendrik Saly <hendrik.saly@eliatra.com> Co-authored-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> Co-authored-by: qianheng <qianheng@amazon.com>

* WIP trendline command Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * wip Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * trendline supports sorting Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * run scalafmtAll Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * return null when there are too few data points Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * sbt scalafmtAll Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * Remove WMA references Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * trendline - sortByField as Optional<Field> Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * introduce TrendlineStrategy Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * keywordsCanBeId -> replace SMA with trendlineType Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * handle trendline alias as qualifiedName instead of fieldExpression Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> * Add docs Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Make alias optional Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Adapt tests for optional alias Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Adden logical plan unittests Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Add missing license headers Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Fix docs Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * numberOfDataPoints must be 1 or greater Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Rename TrendlineStrategy to TrendlineCatalystUtils Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Validate TrendlineType early and pass around enum type Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Add trendline chaining test Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Fix compile errors Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Fix imports Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> * Fix imports Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> --------- Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com> Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com> Co-authored-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com>

salyh requested review from dai-chen, rupal-bq, mengweieric, vamsimanohar, penghuo, seankao-az, anirudha, kaituo, YANG-DB, noCharger, LantaoJin and ykmr1224 as code owners October 29, 2024 21:09

salyh mentioned this pull request Oct 29, 2024

Add trendline command #748

Closed

YANG-DB added Lang:PPL Pipe Processing Language support 0.6 labels Oct 29, 2024

YANG-DB requested changes Oct 29, 2024

View reviewed changes

YANG-DB requested changes Oct 30, 2024

View reviewed changes

ppl-spark-integration/src/main/java/org/opensearch/sql/ppl/CatalystQueryPlanVisitor.java Outdated Show resolved Hide resolved

LantaoJin reviewed Oct 30, 2024

View reviewed changes

ppl-spark-integration/src/main/antlr4/OpenSearchPPLParser.g4 Outdated Show resolved Hide resolved

ppl-spark-integration/src/main/antlr4/OpenSearchPPLParser.g4 Outdated Show resolved Hide resolved

ppl-spark-integration/src/main/antlr4/OpenSearchPPLParser.g4 Show resolved Hide resolved

YANG-DB approved these changes Oct 30, 2024

View reviewed changes

salyh force-pushed the trendline-command-sma branch from 2c04f75 to 4a5d3c1 Compare October 30, 2024 16:59

YANG-DB self-requested a review October 30, 2024 17:40

YANG-DB requested changes Oct 30, 2024

View reviewed changes

YANG-DB approved these changes Oct 30, 2024

View reviewed changes

jduo suggested changes Oct 30, 2024

View reviewed changes

salyh mentioned this pull request Oct 30, 2024

Add trendline PPL command opensearch-project/sql#3071

Merged

7 tasks

LantaoJin previously requested changes Oct 31, 2024

View reviewed changes

kt-eliatra and others added 20 commits October 31, 2024 22:33

return null when there are too few data points

ae751db

Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com>

sbt scalafmtAll

5482ea4

Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com>

Remove WMA references

2fdb506

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

trendline - sortByField as Optional<Field>

25976bb

Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com>

introduce TrendlineStrategy

af4135c

Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com>

keywordsCanBeId -> replace SMA with trendlineType

1545d67

Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com>

handle trendline alias as qualifiedName instead of fieldExpression

931a3ac

Signed-off-by: Kacper Trochimiak <kacper.trochimiak@eliatra.com>

Add docs

a6963d8

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

Make alias optional

cec5740

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

Adapt tests for optional alias

69eb2af

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

Adden logical plan unittests

afaec1b

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

Add missing license headers

5648af0

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

Fix docs

bec3ca4

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

numberOfDataPoints must be 1 or greater

c802bea

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

Rename TrendlineStrategy to TrendlineCatalystUtils

8926855

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

Validate TrendlineType early and pass around enum type

8208bdb

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

Add trendline chaining test

869fc15

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

Fix compile errors

eb01cd9

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

Fix imports

e75a6e9

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

Fix imports

ffcc918

Signed-off-by: Hendrik Saly <hendrik.saly@eliatra.com>

salyh force-pushed the trendline-command-sma branch from 5a51ceb to ffcc918 Compare October 31, 2024 21:38

YANG-DB requested a review from LantaoJin November 1, 2024 19:18

YANG-DB approved these changes Nov 1, 2024

View reviewed changes

YANG-DB merged commit bdb4848 into opensearch-project:main Nov 1, 2024
4 checks passed

andy-k-improving mentioned this pull request Nov 5, 2024

New trendline ppl command (WMA) #872

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New trendline ppl command (SMA only) #833

New trendline ppl command (SMA only) #833

salyh commented Oct 29, 2024

YANG-DB left a comment

YANG-DB left a comment •

edited

Loading

salyh commented Oct 30, 2024

YANG-DB commented Oct 30, 2024

LantaoJin left a comment •

edited

Loading

LantaoJin commented Oct 31, 2024

salyh commented Oct 31, 2024

YANG-DB commented Nov 1, 2024

New trendline ppl command (SMA only) #833

New trendline ppl command (SMA only) #833

Conversation

salyh commented Oct 29, 2024

Description

Related Issues

Check List

YANG-DB left a comment

Choose a reason for hiding this comment

YANG-DB left a comment • edited Loading

Choose a reason for hiding this comment

salyh commented Oct 30, 2024

YANG-DB commented Oct 30, 2024

LantaoJin left a comment • edited Loading

Choose a reason for hiding this comment

LantaoJin commented Oct 31, 2024

salyh commented Oct 31, 2024

YANG-DB commented Nov 1, 2024

YANG-DB left a comment •

edited

Loading

LantaoJin left a comment •

edited

Loading