Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for index options #66

Merged

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Oct 6, 2023

Description

  1. Added validation for option name provided in WITH clause and throw exception for invalid/unknown name
  2. For clarity, Store option with default value in Flint metadata even if unspecified in SQL.

Issues Resolved

#65

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen added the enhancement New feature or request label Oct 6, 2023
@dai-chen dai-chen self-assigned this Oct 6, 2023
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen marked this pull request as ready for review October 9, 2023 17:30
@dai-chen dai-chen merged commit 2c184ca into opensearch-project:main Oct 16, 2023
@dai-chen dai-chen deleted the add-validation-for-index-options branch October 16, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants